All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: bcollins@debian.org
Cc: linux-kernel@vger.kernel.org, linux1394-devel@lists.sourceforge.net
Subject: [2.6 patch] let IEEE1394 select NET
Date: Fri, 13 Aug 2004 12:05:01 +0200	[thread overview]
Message-ID: <20040813100501.GR13377@fs.tum.de> (raw)

Firewire support with CONFIG_NET=n fails with the following error:

<--  snip  -->

...
  LD      .tmp_vmlinux1
drivers/built-in.o(.text+0x3e67d5): In function `hpsb_alloc_packet':
: undefined reference to `alloc_skb'
drivers/built-in.o(.text+0x3e73e7): In function `hpsb_send_packet':
: undefined reference to `skb_queue_tail'
drivers/built-in.o(.text+0x3e8106): In function `abort_requests':
: undefined reference to `skb_dequeue'
drivers/built-in.o(.text+0x3e822e): In function `queue_packet_complete':
: undefined reference to `skb_queue_tail'
drivers/built-in.o(.text+0x3e82b2): In function `hpsbpkt_thread':
: undefined reference to `skb_dequeue'
drivers/built-in.o(.text+0x3e82e2): In function `hpsbpkt_thread':
: undefined reference to `skb_dequeue'
drivers/built-in.o(.text+0x3e6890): In function `hpsb_free_packet':
: undefined reference to `__kfree_skb'
make: *** [.tmp_vmlinux1] Error 1

<--  snip  -->


The following patch fixes this issue by letting IEEE1394 select NET:


Signed-off-by: Adrian Bunk <bunk@fs.tum.de>

--- linux-2.6.8-rc4-mm1-full-3.4/drivers/ieee1394/Kconfig.old	2004-08-13 12:02:48.000000000 +0200
+++ linux-2.6.8-rc4-mm1-full-3.4/drivers/ieee1394/Kconfig	2004-08-13 12:03:04.000000000 +0200
@@ -5,6 +5,7 @@
 config IEEE1394
 	tristate "IEEE 1394 (FireWire) support"
 	depends on PCI || BROKEN
+	select NET
 	help
 	  IEEE 1394 describes a high performance serial bus, which is also
 	  known as FireWire(tm) or i.Link(tm) and is used for connecting all


             reply	other threads:[~2004-08-13 10:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-13 10:05 Adrian Bunk [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-05-29 11:24 error compiling linux-2.6.6 Artemio
2004-05-29 12:14 ` [2.6 patch] let IEEE1394 select NET Adrian Bunk
2004-05-29 12:23   ` Russell King
2004-05-29 12:57     ` Adrian Bunk
2004-05-29 23:55     ` Andy Lutomirski
2004-05-30  0:08       ` Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040813100501.GR13377@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=bcollins@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.