[2.6 patch] let IEEE1394 select NET

[2.6 patch] let IEEE1394 select NET

[Adrian Bunk]

On Sat, May 29, 2004 at 02:24:43PM +0300, Artemio wrote:

> Hello all!

Hi Artemio!

> I am trying to compile a clean, non-patched 2.6.6 kernel from right from 
> kernel.org, using gcc 3.3.2. I have tried both gcc 3.3.2 in uclibc i386 root 
> distribution and gcc 3.3.2-6mdk in mandrake 10.0. With both gcc's, at the end 
> of all, I get:
> 
> [make output]
>   LD      .tmp_vmlinux1
> drivers/built-in.o(.text+0x6ef62): In function `hpsb_alloc_packet':
> : undefined reference to `alloc_skb'
> drivers/built-in.o(.text+0x6f68f): In function `hpsb_packet_sent':
> : undefined reference to `skb_unlink'
> drivers/built-in.o(.text+0x6f82d): In function `hpsb_send_packet':
> : undefined reference to `skb_queue_tail'
> drivers/built-in.o(.text+0x70199): In function `abort_requests':
> : undefined reference to `skb_dequeue'
> drivers/built-in.o(.text+0x7025b): In function `queue_packet_complete':
> : undefined reference to `skb_queue_tail'
> drivers/built-in.o(.text+0x702bf): In function `hpsbpkt_thread':
> : undefined reference to `skb_dequeue'
> drivers/built-in.o(.text+0x6f006): In function `hpsb_free_packet':
> : undefined reference to `__kfree_skb'
> make: *** [.tmp_vmlinux1] Error 1
> [/make output]
> 
> Could someone please tell me what to do? :-/
> 
> I'd really appreciate any help. 
>...

Thanks for this report.

FireWire support requires Networking support.

The following patch lets FireWire support automatically select 
Networking support:

--- linux-2.6.7-rc1-mm1-full/drivers/ieee1394/Kconfig.old	2004-05-29 14:07:55.000000000 +0200
+++ linux-2.6.7-rc1-mm1-full/drivers/ieee1394/Kconfig	2004-05-29 14:08:13.000000000 +0200
@@ -4,6 +4,7 @@
 
 config IEEE1394
 	tristate "IEEE 1394 (FireWire) support"
+	select NET
 	help
 	  IEEE 1394 describes a high performance serial bus, which is also
 	  known as FireWire(tm) or i.Link(tm) and is used for connecting all


> Artemio.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [2.6 patch] let IEEE1394 select NET

[Russell King]

On Sat, May 29, 2004 at 02:14:08PM +0200, Adrian Bunk wrote:
> The following patch lets FireWire support automatically select 
> Networking support:

And so we get another fscking symbol which has a non-obvious way to
turn it off.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core

Re: [2.6 patch] let IEEE1394 select NET

[Adrian Bunk]

On Sat, May 29, 2004 at 01:23:56PM +0100, Russell King wrote:
> On Sat, May 29, 2004 at 02:14:08PM +0200, Adrian Bunk wrote:
> > The following patch lets FireWire support automatically select 
> > Networking support:
> 
> And so we get another fscking symbol which has a non-obvious way to
> turn it off.

Alternatively, the following patch would also solve this issue:

--- linux-2.6.7-rc1-mm1-full/drivers/ieee1394/Kconfig.old	2004-05-29 14:07:55.000000000 +0200
+++ linux-2.6.7-rc1-mm1-full/drivers/ieee1394/Kconfig	2004-05-29 14:56:02.000000000 +0200
@@ -4,6 +4,7 @@
 
 config IEEE1394
 	tristate "IEEE 1394 (FireWire) support"
+	depends on NET
 	help
 	  IEEE 1394 describes a high performance serial bus, which is also
 	  known as FireWire(tm) or i.Link(tm) and is used for connecting all


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [2.6 patch] let IEEE1394 select NET

[Andy Lutomirski]

Russell King wrote:

> On Sat, May 29, 2004 at 02:14:08PM +0200, Adrian Bunk wrote:
> 
>>The following patch lets FireWire support automatically select 
>>Networking support:
> 
> 
> And so we get another fscking symbol which has a non-obvious way to
> turn it off.
> 

Is it possible to make xconfig and menuconfig show what has an option selected?

--Andy

Re: [2.6 patch] let IEEE1394 select NET

[Randy.Dunlap]

On Sat, 29 May 2004 16:55:24 -0700 Andy Lutomirski <luto@myrealbox.com> wrote:

| Russell King wrote:
| 
| > On Sat, May 29, 2004 at 02:14:08PM +0200, Adrian Bunk wrote:
| > 
| >>The following patch lets FireWire support automatically select 
| >>Networking support:
| > 
| > 
| > And so we get another fscking symbol which has a non-obvious way to
| > turn it off.
| > 
| 
| Is it possible to make xconfig and menuconfig show what has an option selected?

It's possible to "Show all options" and several other gui options
in xconfig.  I don't know of similar options in menuconfig.

The xconfig options are useful for debugging where options are
defined, what controls them, etc.

--
~Randy

[2.6 patch] let IEEE1394 select NET

[Adrian Bunk]

Firewire support with CONFIG_NET=n fails with the following error:

<--  snip  -->

...
  LD      .tmp_vmlinux1
drivers/built-in.o(.text+0x3e67d5): In function `hpsb_alloc_packet':
: undefined reference to `alloc_skb'
drivers/built-in.o(.text+0x3e73e7): In function `hpsb_send_packet':
: undefined reference to `skb_queue_tail'
drivers/built-in.o(.text+0x3e8106): In function `abort_requests':
: undefined reference to `skb_dequeue'
drivers/built-in.o(.text+0x3e822e): In function `queue_packet_complete':
: undefined reference to `skb_queue_tail'
drivers/built-in.o(.text+0x3e82b2): In function `hpsbpkt_thread':
: undefined reference to `skb_dequeue'
drivers/built-in.o(.text+0x3e82e2): In function `hpsbpkt_thread':
: undefined reference to `skb_dequeue'
drivers/built-in.o(.text+0x3e6890): In function `hpsb_free_packet':
: undefined reference to `__kfree_skb'
make: *** [.tmp_vmlinux1] Error 1

<--  snip  -->


The following patch fixes this issue by letting IEEE1394 select NET:


Signed-off-by: Adrian Bunk <bunk@fs.tum.de>

--- linux-2.6.8-rc4-mm1-full-3.4/drivers/ieee1394/Kconfig.old	2004-08-13 12:02:48.000000000 +0200
+++ linux-2.6.8-rc4-mm1-full-3.4/drivers/ieee1394/Kconfig	2004-08-13 12:03:04.000000000 +0200
@@ -5,6 +5,7 @@
 config IEEE1394
 	tristate "IEEE 1394 (FireWire) support"
 	depends on PCI || BROKEN
+	select NET
 	help
 	  IEEE 1394 describes a high performance serial bus, which is also
 	  known as FireWire(tm) or i.Link(tm) and is used for connecting all