From: Alan Cox <alan@redhat.com>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: Alan Cox <alan@redhat.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
torvalds@osdl.org
Subject: Re: PATCH: switch ide-proc to use the ide_key functionality
Date: Mon, 16 Aug 2004 20:41:28 -0400 [thread overview]
Message-ID: <20040817004128.GA32628@devserv.devel.redhat.com> (raw)
In-Reply-To: <200408170231.25725.bzolnier@elka.pw.edu.pl>
On Tue, Aug 17, 2004 at 02:31:25AM +0200, Bartlomiej Zolnierkiewicz wrote:
> > > It is also still racy for some drivers because ide_register_hw() ->
> > > init_hwif_data() sets hwif->key to zero - you must set hwif->hold to 1.
> >
> > ide_register_hw holds ide_setting_sem. I think that should be ok ?
>
> ide_setting_sem doesn't help situation when hwif is unregistered and some
> other driver is loaded later and takes this hwif using ide_register_hw().
Right - ide_cfg_sem is covering this. ide_cfg_sem is taken after
ide_setting_sem so how about making init_hwif_data restore that field.
ide_drive_from_key can then take ide_cfg_sem during its checking
The other alternative is to never use key = 0 in the real world but I
see no reason for not just taking ide_cfg_sem during the key to drive
operation. ide_cfg_sem is the read lock for configuration change so this
is logically the right behaviour too ?
next prev parent reply other threads:[~2004-08-17 0:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-15 15:04 PATCH: switch ide-proc to use the ide_key functionality Alan Cox
2004-08-16 15:24 ` Bartlomiej Zolnierkiewicz
2004-08-16 15:30 ` Alan Cox
2004-08-16 23:22 ` Bartlomiej Zolnierkiewicz
2004-08-16 23:35 ` Bartlomiej Zolnierkiewicz
2004-08-17 0:13 ` Alan Cox
2004-08-17 0:31 ` Bartlomiej Zolnierkiewicz
2004-08-17 0:41 ` Alan Cox [this message]
2004-08-17 1:05 ` Alan Cox
2004-08-17 10:48 ` Bartlomiej Zolnierkiewicz
2004-08-17 12:06 ` Alan Cox
2004-08-17 22:15 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040817004128.GA32628@devserv.devel.redhat.com \
--to=alan@redhat.com \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.