Re: Fw: 2.6.8.1-mm1: oops with firmware loading

Re: Fw: 2.6.8.1-mm1: oops with firmware loading

[Maneesh Soni]

On Tue, Aug 17, 2004 at 11:05:33AM -0700, Andrew Morton wrote:
> 
> 
> Begin forwarded message:
> 
> Date: Tue, 17 Aug 2004 15:28:18 +0200
> From: Manuel Lauss <manuel.lauss@fh-hagenberg.at>
> To: akpm@osdl.org, linux-kernel@vger.kernel.org
> Cc: manuel.lauss@fh-hagenberg.at
> Subject: 2.6.8.1-mm1: oops with firmware loading
> 
> 
> Hi,
> 
> The new sysfs-backingstore patches cause an oops when I ifup a
> prism54 based device, heres the dmesg section:
> 

My fault, a bad typo in fs/sysfs/bin.c.

Manuel, can you try this change in fs/sysfs/bin.c

--- bin.c.orig	2004-08-18 05:34:40.883964168 +0530
+++ bin.c	2004-08-18 05:36:40.316807616 +0530
@@ -60,8 +60,8 @@
 static int
 flush_write(struct dentry *dentry, char *buffer, loff_t offset, size_t count)
 {
-	struct bin_attribute *attr = to_bin_attr(dentry->d_parent);
-	struct kobject *kobj = to_kobj(dentry);
+	struct bin_attribute *attr = to_bin_attr(dentry);
+	struct kobject *kobj = to_kobj(dentry->d_parent);
 
 	return attr->write(kobj, buffer, offset, count);
 }


Andrew, How do I send the patch? I think hand editting will also work.

Thanks
Maneesh


-- 
Maneesh Soni
Linux Technology Center, 
IBM Austin
email: maneesh@in.ibm.com
Phone: 1-512-838-1896 Fax: 
T/L : 6781896

Re: Fw: 2.6.8.1-mm1: oops with firmware loading

[Manuel Lauss]

Maneesh Soni wrote:

[...]

> My fault, a bad typo in fs/sysfs/bin.c.
> 
> Manuel, can you try this change in fs/sysfs/bin.c

<patch snipped>

yup, works, thanks!

-- 
Manuel Lauss
Student HSSE / FH Hagenberg