All of lore.kernel.org
 help / color / mirror / Atom feed
From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] Re: list_for_each: arch-alpha-kernel-pci.c
Date: Fri, 20 Aug 2004 10:21:06 +0000	[thread overview]
Message-ID: <20040820102106.GB2592@masina.coderock.org> (raw)
In-Reply-To: <20040820094611.GA2592@masina.coderock.org>

[-- Attachment #1: Type: text/plain, Size: 773 bytes --]

On 20/08/04 06:29 +0100, Christoph Hellwig wrote:
> On Thu, Aug 19, 2004 at 01:11:18PM +0200, Domen Puncer wrote:
> > Hi.
> > 
> > Change for loops with list_for_each().
> 
> Please go directly to list_for_each_entry in all your patches where possible.

Or are you implying that code like:
        list_for_each(ln, &bus->devices) {
                struct pci_dev *dev = pci_dev_b(ln);

could be list_for_each_entry, since pci_dev_b is basically a list_entry?
If that is the case, what was the reason for pci_dev_b in first place?
More readability or maybe abstraction of pci code?


Thanks,

	Domen

> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> http://lists.osdl.org/mailman/listinfo/kernel-janitors


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

  reply	other threads:[~2004-08-20 10:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-20  9:46 [Kernel-janitors] Re: list_for_each: arch-alpha-kernel-pci.c Domen Puncer
2004-08-20 10:21 ` Domen Puncer [this message]
2004-08-20 12:46 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040820102106.GB2592@masina.coderock.org \
    --to=domen@coderock.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.