[Kernel-janitors] Re: list_for_each: arch-alpha-kernel-pci.c

[Kernel-janitors] Re: list_for_each: arch-alpha-kernel-pci.c

[Domen Puncer]

[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

On 20/08/04 06:29 +0100, Christoph Hellwig wrote:
> On Thu, Aug 19, 2004 at 01:11:18PM +0200, Domen Puncer wrote:
> > Hi.
> > 
> > Change for loops with list_for_each().
> 
> Please go directly to list_for_each_entry in all your patches where possible.

Well, i did that on Jul 29. (these and those patches are forward ports
from an old patchset).


> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> http://lists.osdl.org/mailman/listinfo/kernel-janitors


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] Re: list_for_each: arch-alpha-kernel-pci.c

[Domen Puncer]

[-- Attachment #1: Type: text/plain, Size: 773 bytes --]

On 20/08/04 06:29 +0100, Christoph Hellwig wrote:
> On Thu, Aug 19, 2004 at 01:11:18PM +0200, Domen Puncer wrote:
> > Hi.
> > 
> > Change for loops with list_for_each().
> 
> Please go directly to list_for_each_entry in all your patches where possible.

Or are you implying that code like:
        list_for_each(ln, &bus->devices) {
                struct pci_dev *dev = pci_dev_b(ln);

could be list_for_each_entry, since pci_dev_b is basically a list_entry?
If that is the case, what was the reason for pci_dev_b in first place?
More readability or maybe abstraction of pci code?


Thanks,

	Domen

> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> http://lists.osdl.org/mailman/listinfo/kernel-janitors


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] Re: list_for_each: arch-alpha-kernel-pci.c

[Christoph Hellwig]

[-- Attachment #1: Type: text/plain, Size: 715 bytes --]

On Fri, Aug 20, 2004 at 12:21:06PM +0200, Domen Puncer wrote:
> On 20/08/04 06:29 +0100, Christoph Hellwig wrote:
> > On Thu, Aug 19, 2004 at 01:11:18PM +0200, Domen Puncer wrote:
> > > Hi.
> > > 
> > > Change for loops with list_for_each().
> > 
> > Please go directly to list_for_each_entry in all your patches where possible.
> 
> Or are you implying that code like:
>         list_for_each(ln, &bus->devices) {
>                 struct pci_dev *dev = pci_dev_b(ln);
> 
> could be list_for_each_entry, since pci_dev_b is basically a list_entry?

Yes.

> If that is the case, what was the reason for pci_dev_b in first place?
> More readability or maybe abstraction of pci code?

It predactes list_for_each_entry

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors