From: maximilian attems <janitor@sternwelten.at>
To: Jay Bourque <kernel@uranium235.org>
Cc: kernel-janitors@lists.osdl.org, netdev@oss.sgi.com
Subject: Re: [Kernel-janitors] ip_gre.c: update last_rx after netif_rx
Date: Sat, 21 Aug 2004 08:36:39 +0000 [thread overview]
Message-ID: <20040821083639.GA1827@stro.at> (raw)
In-Reply-To: <411E62D3.8070808@uranium235.org>
[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]
On Sat, 14 Aug 2004, Jay Bourque wrote:
> Fix to update last_rx after netif_rx
> This is my first patch so I'd appreciate any feedback.
>
> -Jay
>
> --- linux-2.6.8.1/net/ipv4/ip_gre.c Sat Aug 14 05:55:48 2004
> +++ linux-2.6.8.1/net/ipv4/ip_gre.c.new Sat Aug 14 12:17:16 2004
> @@ -646,6 +646,7 @@ int ipgre_rcv(struct sk_buff *skb)
> nf_reset(skb);
> ipgre_ecn_decapsulate(iph, skb);
> netif_rx(skb);
> + tunnel->dev->last_rx = jiffies;
> read_unlock(&ipgre_lock);
> return(0);
> }
doesn't look complete, see patch below, but please read on:
the kj todo has an entry about "update last_rx after netif_rx",
i wonder what that timestamping is good for, and newer
sources 2.4.27 and 2.6.8 show 2 occurences of last_rx.
patches doing that are for young 2.4:
http://seclists.org/linux-kernel/2001/Feb/4846.html
i presume that this task is outdated,
thanks for putting light on that.
--
maks
kernel janitor http://janitor.kernelnewbies.org/
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
WARNING: multiple messages have this Message-ID (diff)
From: maximilian attems <janitor@sternwelten.at>
To: Jay Bourque <kernel@uranium235.org>
Cc: kernel-janitors@lists.osdl.org, netdev@oss.sgi.com
Subject: Re: [Kernel-janitors] ip_gre.c: update last_rx after netif_rx
Date: Sat, 21 Aug 2004 10:36:39 +0200 [thread overview]
Message-ID: <20040821083639.GA1827@stro.at> (raw)
In-Reply-To: <411E62D3.8070808@uranium235.org>
On Sat, 14 Aug 2004, Jay Bourque wrote:
> Fix to update last_rx after netif_rx
> This is my first patch so I'd appreciate any feedback.
>
> -Jay
>
> --- linux-2.6.8.1/net/ipv4/ip_gre.c Sat Aug 14 05:55:48 2004
> +++ linux-2.6.8.1/net/ipv4/ip_gre.c.new Sat Aug 14 12:17:16 2004
> @@ -646,6 +646,7 @@ int ipgre_rcv(struct sk_buff *skb)
> nf_reset(skb);
> ipgre_ecn_decapsulate(iph, skb);
> netif_rx(skb);
> + tunnel->dev->last_rx = jiffies;
> read_unlock(&ipgre_lock);
> return(0);
> }
doesn't look complete, see patch below, but please read on:
the kj todo has an entry about "update last_rx after netif_rx",
i wonder what that timestamping is good for, and newer
sources 2.4.27 and 2.6.8 show 2 occurences of last_rx.
patches doing that are for young 2.4:
http://seclists.org/linux-kernel/2001/Feb/4846.html
i presume that this task is outdated,
thanks for putting light on that.
--
maks
kernel janitor http://janitor.kernelnewbies.org/
next prev parent reply other threads:[~2004-08-21 8:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-14 19:06 [Kernel-janitors] ip_gre.c: update last_rx after netif_rx Jay Bourque
2004-08-16 8:38 ` maximilian attems
2004-08-21 8:36 ` maximilian attems [this message]
2004-08-21 8:36 ` maximilian attems
2004-08-23 20:36 ` max attems
2004-08-23 20:36 ` max attems
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040821083639.GA1827@stro.at \
--to=janitor@sternwelten.at \
--cc=kernel-janitors@lists.osdl.org \
--cc=kernel@uranium235.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.