banias with different (unusual?) model_name

banias with different (unusual?) model_name

[matthias brill]

[-- Attachment #1: Type: text/plain, Size: 1651 bytes --]

hi jeremy

i've found a pentium-m banias which reports "Mobile Genuine Intel(R)
processor       1400MHz" in /proc/cpuinfo.  this (strange?) signature
prevents speedstep-centrino.c from working properly.

the machine is a asus L4000R-series (L4510RBP) pentium-m/ati9100igp
notebook.

"Enhanced SpeedStep" works as advertised for this particular pentium-m
with the following trivial patch applied:

# diff -up arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c.default arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c
--- arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c.default	2004-08-19 19:53:59.000000000 +0200
+++ arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c	2004-08-19 20:49:06.000000000 +0200
@@ -195,7 +195,7 @@ static struct cpufreq_frequency_table ba
 
 #define _BANIAS(cpuid, max, name)	\
 {	.cpu_id		= cpuid,	\
-	.model_name	= "Intel(R) Pentium(R) M processor " name "MHz", \
+	.model_name	= "Mobile Genuine Intel(R) processor       " name "MHz", \
 	.max_freq	= (max)*1000,	\
 	.op_points	= banias_##max,	\
 }

it seems that only the model_name is different for this CPU?

thias


# cat /proc/cpuinfo
processor	: 0
vendor_id	: GenuineIntel
cpu family	: 6
model		: 9
model name	: Mobile Genuine Intel(R) processor       1400MHz
stepping	: 5
cpu MHz		: 600.087
cache size	: 1024 KB
fdiv_bug	: no
hlt_bug		: no
f00f_bug	: no
coma_bug	: no
fpu		: yes
fpu_exception	: yes
cpuid level	: 2
wp		: yes
flags		: fpu vme de pse tsc msr mce cx8 apic sep mtrr pge mca cmov pat clflush dts acpi mmx fxsr sse sse2 tm pbe tm2 est
bogomips	: 1190.18

-- 
Matthias Brill <matthias.brill@akamail.com>

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: banias with different (unusual?) model_name

[Alan Cox]

On Gwe, 2004-08-20 at 10:33, matthias brill wrote:
> hi jeremy
> 
> i've found a pentium-m banias which reports "Mobile Genuine Intel(R)
> processor       1400MHz" in /proc/cpuinfo.  this (strange?) signature
> prevents speedstep-centrino.c from working properly.

Signatures appear to be BIOS set so that would make sense.


> # diff -up arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c.default arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c
> --- arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c.default	2004-08-19 19:53:59.000000000 +0200
> +++ arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c	2004-08-19 20:49:06.000000000 +0200
> @@ -195,7 +195,7 @@ static struct cpufreq_frequency_table ba
>  
>  #define _BANIAS(cpuid, max, name)	\
>  {	.cpu_id		= cpuid,	\
> -	.model_name	= "Intel(R) Pentium(R) M processor " name "MHz", \
> +	.model_name	= "Mobile Genuine Intel(R) processor       " name "MHz", \
>  	.max_freq	= (max)*1000,	\
>  	.op_points	= banias_##max,	\
>  }
> 

You need a new entry "_WEIRDBANIAS" and entries in the table so that
you don't break other people by such a change but yes

> it seems that only the model_name is different for this CPU?

Re: banias with different (unusual?) model_name

[matthias brill]

[-- Attachment #1.1: Type: text/plain, Size: 1508 bytes --]

hi alan, jeremy

On Fri, Aug 20, 2004 at 02:25:36PM +0100, Alan Cox wrote:
> > i've found a pentium-m banias which reports "Mobile Genuine Intel(R)
> > processor       1400MHz" in /proc/cpuinfo.  this (strange?) signature
> > prevents speedstep-centrino.c from working properly.
> 
> Signatures appear to be BIOS set so that would make sense.

that fact wasn't obvious to me -- i've updated the BIOS and the strange
banias signature is now gone.  it reports the expected "Intel(R)
Pentium(R) M processor 1400MHz" string now.

in excess the "ACPI-behaviour" changes from "totally broken" to "not
working" which is kind of a progress... 8-}


On Fri, Aug 20, 2004 at 07:19:31PM -0700, Jeremy Fitzhardinge wrote:
> Yeah, there seem to be a few of these around.  I'm just not certain that
> they're identical to "normal" Banias as far as operating points go.

it seems that the reported value depends on the mental health of the
BIOS-programmer at hand, therefore the suplied string might not be
trustworthy.

if i understand correctly, the type of the cpu can be determined by
looking at the family, model and stepping -- assuming that these values
are reported directly  by the CPUID (0FA2) instruction. 

the BIOS supplied model_name string in speedstep-centrino.c is parsed to
get the clock cycle time of the cpu.  is this actually supposed to be
the "right" way (or worse: the only way) to get this information?


thias

-- 
Matthias Brill <matthias.brill@akamail.com>

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 143 bytes --]

_______________________________________________
Cpufreq mailing list
Cpufreq@www.linux.org.uk
http://www.linux.org.uk/mailman/listinfo/cpufreq

Re: banias with different (unusual?) model_name

[matthias brill]

[-- Attachment #1: Type: text/plain, Size: 1508 bytes --]

hi alan, jeremy

On Fri, Aug 20, 2004 at 02:25:36PM +0100, Alan Cox wrote:
> > i've found a pentium-m banias which reports "Mobile Genuine Intel(R)
> > processor       1400MHz" in /proc/cpuinfo.  this (strange?) signature
> > prevents speedstep-centrino.c from working properly.
> 
> Signatures appear to be BIOS set so that would make sense.

that fact wasn't obvious to me -- i've updated the BIOS and the strange
banias signature is now gone.  it reports the expected "Intel(R)
Pentium(R) M processor 1400MHz" string now.

in excess the "ACPI-behaviour" changes from "totally broken" to "not
working" which is kind of a progress... 8-}


On Fri, Aug 20, 2004 at 07:19:31PM -0700, Jeremy Fitzhardinge wrote:
> Yeah, there seem to be a few of these around.  I'm just not certain that
> they're identical to "normal" Banias as far as operating points go.

it seems that the reported value depends on the mental health of the
BIOS-programmer at hand, therefore the suplied string might not be
trustworthy.

if i understand correctly, the type of the cpu can be determined by
looking at the family, model and stepping -- assuming that these values
are reported directly  by the CPUID (0FA2) instruction. 

the BIOS supplied model_name string in speedstep-centrino.c is parsed to
get the clock cycle time of the cpu.  is this actually supposed to be
the "right" way (or worse: the only way) to get this information?


thias

-- 
Matthias Brill <matthias.brill@akamail.com>

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: banias with different (unusual?) model_name

[Dave Jones]

On Sat, Aug 21, 2004 at 01:53:16PM +0200, matthias brill wrote:

 > if i understand correctly, the type of the cpu can be determined by
 > looking at the family, model and stepping -- assuming that these values
 > are reported directly  by the CPUID (0FA2) instruction. 

download the source for x86info sometime, and look at the hoops
it jumps through to determine what cpu its running on. It isn't
just as simple as a few cpuid calls any more. These days there are
typically up to a half dozen factors that you need to look at to
discriminate between possibilities. One of these, is cpu speed.
Unfortunatly, as we could have booted off mains, and hence a lower
clock speed, we can't do any runtime calculation like we do with
bogomips/jiffies, so we have to resort to looking at the model name
supplied by the BIOS.

 > the BIOS supplied model_name string in speedstep-centrino.c is parsed to
 > get the clock cycle time of the cpu.  is this actually supposed to be
 > the "right" way (or worse: the only way) to get this information?

It's pretty much all we have that we can trust.  If we could
do something else, I'd love to, as I distrust the abilities of
BIOS programmers as much as anyone else.

		Dave

Re: banias with different (unusual?) model_name

[Dave Jones]

On Sat, Aug 21, 2004 at 01:53:16PM +0200, matthias brill wrote:

 > if i understand correctly, the type of the cpu can be determined by
 > looking at the family, model and stepping -- assuming that these values
 > are reported directly  by the CPUID (0FA2) instruction. 

download the source for x86info sometime, and look at the hoops
it jumps through to determine what cpu its running on. It isn't
just as simple as a few cpuid calls any more. These days there are
typically up to a half dozen factors that you need to look at to
discriminate between possibilities. One of these, is cpu speed.
Unfortunatly, as we could have booted off mains, and hence a lower
clock speed, we can't do any runtime calculation like we do with
bogomips/jiffies, so we have to resort to looking at the model name
supplied by the BIOS.

 > the BIOS supplied model_name string in speedstep-centrino.c is parsed to
 > get the clock cycle time of the cpu.  is this actually supposed to be
 > the "right" way (or worse: the only way) to get this information?

It's pretty much all we have that we can trust.  If we could
do something else, I'd love to, as I distrust the abilities of
BIOS programmers as much as anyone else.

		Dave

Re: Another mobile stepping - speedstep works fine

[Jeremy Fitzhardinge]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

On Fri, 2004-08-20 at 14:29 +0100, Alan Cox wrote:
> I just added the stepping and ran some testing. Its been running with
> cpuspeed daemon for a day now and seems fine.

Thanks.  The driver looks a bit different now, so I've recast the patch.

David, could you put this in your tree?

Thanks,
	J

[-- Attachment #2: sc-ac-dothan-a2.patch --]
[-- Type: text/x-patch, Size: 1040 bytes --]

 arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c |    3 +++
 1 files changed, 3 insertions(+)

diff -puN arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c~sc-ac-dothan-a2 arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c
--- local-2.6/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c~sc-ac-dothan-a2	2004-08-20 09:45:21.358254383 -0700
+++ local-2.6-jeremy/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c	2004-08-20 09:45:57.315356194 -0700
@@ -53,12 +53,14 @@ struct cpu_id
 enum {
 	CPU_BANIAS,
 	CPU_DOTHAN_A1,
+	CPU_DOTHAN_A2,
 	CPU_DOTHAN_B0,
 };
 
 static const struct cpu_id cpu_ids[] = {
 	[CPU_BANIAS]	= { 6,  9, 5 },
 	[CPU_DOTHAN_A1]	= { 6, 13, 1 },
+	[CPU_DOTHAN_A2]	= { 6, 13, 2 },
 	[CPU_DOTHAN_B0]	= { 6, 13, 6 },
 };
 #define N_IDS	(sizeof(cpu_ids)/sizeof(cpu_ids[0]))
@@ -221,6 +223,7 @@ static struct cpu_model models[] =
 
 	/* NULL model_name is a wildcard */
 	{ &cpu_ids[CPU_DOTHAN_A1], NULL, 0, NULL },
+	{ &cpu_ids[CPU_DOTHAN_A2], NULL, 0, NULL },
 	{ &cpu_ids[CPU_DOTHAN_B0], NULL, 0, NULL },
 
 	{ NULL, }

_

[-- Attachment #3: Type: text/plain, Size: 143 bytes --]

_______________________________________________
Cpufreq mailing list
Cpufreq@www.linux.org.uk
http://www.linux.org.uk/mailman/listinfo/cpufreq

Re: Another mobile stepping - speedstep works fine

[Dave Jones]

On Fri, Aug 20, 2004 at 12:21:25PM -0700, Jeremy Fitzhardinge wrote:
 > On Fri, 2004-08-20 at 14:29 +0100, Alan Cox wrote:
 > > I just added the stepping and ran some testing. Its been running with
 > > cpuspeed daemon for a day now and seems fine.
 > 
 > Thanks.  The driver looks a bit different now, so I've recast the patch.
 > 
 > David, could you put this in your tree?

ACK. Merged, and queued for next weeks mainline cpufreq patchbomb.

		Dave

Re: Another mobile stepping - speedstep works fine

[Jeremy Fitzhardinge]

On Fri, 2004-08-20 at 20:36 +0100, Dave Jones wrote:
> ACK. Merged, and queued for next weeks mainline cpufreq patchbomb.

Thanks.  Is that aimed at 2.6.9, or 2.6.8.2?  Sooner the better for me,
since a lot of people seem to be mailing me about Dothan...

	J

Re: Another mobile stepping - speedstep works fine

[Dave Jones]

On Fri, Aug 20, 2004 at 03:33:49PM -0700, Jeremy Fitzhardinge wrote:
 > On Fri, 2004-08-20 at 20:36 +0100, Dave Jones wrote:
 > > ACK. Merged, and queued for next weeks mainline cpufreq patchbomb.
 > 
 > Thanks.  Is that aimed at 2.6.9, or 2.6.8.2?  Sooner the better for me,
 > since a lot of people seem to be mailing me about Dothan...

I'll ask Linus to pull as soon as he gets back.  My guess is that 2.6.8.2
would be reserved for anything really critical, so its likely they'll
turn up in 2.6.9rc1.

		Dave

Re: banias with different (unusual?) model_name

[Jeremy Fitzhardinge]

On Fri, 2004-08-20 at 11:33 +0200, matthias brill wrote:
> hi jeremy
> 
> i've found a pentium-m banias which reports "Mobile Genuine Intel(R)
> processor       1400MHz" in /proc/cpuinfo.  this (strange?) signature
> prevents speedstep-centrino.c from working properly.

Yeah, there seem to be a few of these around.  I'm just not certain that
they're identical to "normal" Banias as far as operating points go.

	J