From: Andreas Dilger <adilger@clusterfs.com>
To: Christoph Hellwig <hch@infradead.org>,
James Morris <jmorris@redhat.com>, Andrew Morton <akpm@osdl.org>,
viro@parcelfarce.linux.theplanet.co.uk,
Stephen Smalley <sds@epoch.ncsc.mil>,
linux-kernel@vger.kernel.org, Chris Wright <chrisw@osdl.org>,
Andreas Gruenbacher <agruen@suse.de>
Subject: Re: [PATCH][2/7] xattr consolidation - LSM hook changes
Date: Mon, 23 Aug 2004 17:28:02 -0600 [thread overview]
Message-ID: <20040823232802.GD1262@schnapps.adilger.int> (raw)
In-Reply-To: <20040823200353.A20114@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 824 bytes --]
On Aug 23, 2004 20:03 +0100, Christoph Hellwig wrote:
> On Mon, Aug 23, 2004 at 02:16:17PM -0400, James Morris wrote:
> > This patch replaces the dentry parameter with an inode in the LSM
> > inode_{set|get|list}security hooks, in keeping with the ext2/ext3 code.
> > dentries are not needed here.
>
> Given that the actual methods take a dentry this sounds like a bad design.
> Can;t you just pass down the dentry through all of the ext2 interfaces?
>
> (And again, mid-term these checks should move to the VFS)
Actually, I recall something about it being desirable to pass the dentry
down instead of just the inode, maybe Andreas G. recalls?
Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://members.shaw.ca/adilger/ http://members.shaw.ca/golinux/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-08-23 23:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-23 18:14 [PATCH][0/7] xattr consolidation and support for ramfs & tmpfs James Morris
2004-08-23 18:15 ` [PATCH][1/7] xattr consolidation - libfs James Morris
2004-08-23 18:16 ` [PATCH][2/7] xattr consolidation - LSM hook changes James Morris
2004-08-23 18:17 ` [PATCH][3/7] xattr consolidation - ext3 James Morris
2004-08-23 18:18 ` [PATCH][4/7] xattr consolidation - ext2 James Morris
2004-08-23 18:19 ` [5/7] xattr consolidation - devpts James Morris
2004-08-23 18:20 ` [PATCH][6/7] add xattr support to tmpfs James Morris
2004-08-23 18:22 ` [PATCH][7/7] add xattr support to ramfs James Morris
2004-08-23 20:26 ` Christoph Hellwig
2004-08-23 20:26 ` Stephen Smalley
2004-08-23 20:46 ` Christoph Hellwig
2004-08-23 20:59 ` Greg KH
2004-08-23 21:27 ` [PATCH][7/7] add xattr support to ramfs [u] Martin Schlemmer [c]
2004-08-24 0:52 ` [PATCH][7/7] add xattr support to ramfs Valdis.Kletnieks
2004-08-24 11:27 ` Stephen Smalley
2004-08-25 7:03 ` Miles Bader
2004-08-25 13:14 ` James Morris
2004-08-23 19:06 ` [PATCH][6/7] add xattr support to tmpfs Christoph Hellwig
2004-08-23 19:03 ` [PATCH][2/7] xattr consolidation - LSM hook changes Christoph Hellwig
2004-08-23 19:06 ` James Morris
2004-08-23 19:13 ` Stephen Smalley
2004-08-24 0:54 ` James Morris
2004-08-24 2:52 ` viro
2004-08-24 19:27 ` Andreas Gruenbacher
2004-08-23 23:28 ` Andreas Dilger [this message]
2004-08-23 18:49 ` [PATCH][1/7] xattr consolidation - libfs Christoph Hellwig
2004-08-24 4:32 ` James Morris
2004-08-24 10:05 ` Christoph Hellwig
2004-08-24 19:42 ` Andreas Gruenbacher
2004-08-24 20:19 ` James Morris
2004-08-24 19:41 ` [PATCH][0/7] xattr consolidation and support for ramfs & tmpfs Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040823232802.GD1262@schnapps.adilger.int \
--to=adilger@clusterfs.com \
--cc=agruen@suse.de \
--cc=akpm@osdl.org \
--cc=chrisw@osdl.org \
--cc=hch@infradead.org \
--cc=jmorris@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sds@epoch.ncsc.mil \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.