From: Russell King <rmk@arm.linux.org.uk>
To: cpufreq@www.linux.org.uk
Subject: Re: cpufreq/linux/arch/arm/mach-sa1100 cpu-sa1100.c, 1.5, 1.6 cpu-sa1110.c, 1.12, 1.13
Date: Thu, 26 Aug 2004 15:15:40 +0100 [thread overview]
Message-ID: <20040826151540.F21364@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20040826151034.E21364@flint.arm.linux.org.uk>; from rmk@arm.linux.org.uk on Thu, Aug 26, 2004 at 03:10:34PM +0100
On Thu, Aug 26, 2004 at 03:10:34PM +0100, Russell King wrote:
> On Thu, Aug 26, 2004 at 02:25:51PM +0100, Ducrot Bruno wrote:
> > Update of /mnt/src/cvsroot/cpufreq/linux/arch/arm/mach-sa1100
> > In directory flint:/tmp/cvs-serv26017/linux/arch/arm/mach-sa1100
> > @@ -329,8 +329,12 @@
> > }
> >
> > static struct cpufreq_driver sa1110_driver = {
> > + .flags = CPUFREQ_STICKY |
>
> > + CPUFREQ_PANIC_OUTOFSYNC | <<<<
> > + CPUFREQ_PANIC_RESUME_OUTOFSYNC, <<<<
>
> Erm, _why_ ?
>
> This makes very little sense. If you put the system to sleep at
> 147MHz and it normally boots at 206.4MHz, you'll resume at 206.4MHz.
>
> It's up to the kernel to reset the clock rate itself. This is nothing
> new - cpufreq has always done this, so why are we adding this new
> restriction?
>
> It makes zero sense.
And to follow that up, yes, I missed it back in June when I added
the CPUFREQ_STICKY here. However, I was completely unaware that
this change had been made back in May 2004.
Can we please route changes to architecture files via the architecture
people _before_ merging them. Pretty please?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-08-26 14:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-26 13:25 cpufreq/linux/arch/arm/mach-sa1100 cpu-sa1100.c, 1.5, 1.6 cpu-sa1110.c, 1.12, 1.13 Ducrot Bruno
2004-08-26 14:10 ` Russell King
2004-08-26 14:15 ` Russell King [this message]
2004-08-26 16:57 ` Bruno Ducrot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040826151540.F21364@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=cpufreq@www.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.