From: "Randy.Dunlap" <rddunlap@osdl.org>
To: dougg@torque.net
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] normalize fixed and descriptor sense data
Date: Fri, 27 Aug 2004 08:46:05 -0700 [thread overview]
Message-ID: <20040827084605.40eebd63.rddunlap@osdl.org> (raw)
In-Reply-To: <412EF74A.1070106@torque.net>
On Fri, 27 Aug 2004 18:56:42 +1000 Douglas Gilbert wrote:
| After the comments on the RFC for this thread, here is
| a patch against lk 2.6.9-rc1 to kick around.
|
A few more style comments to go along with Christoph's comments.
a. Linux long comment style begins with "/*" on a line by itself.
b. sizeof xyz: style is usually sizeof(xyz)
[I find 440 of: sizeof xyz
2106 of: sizeof (xyz)
26948 of: sizeof(xyz)
in 2.6.8.1]
c. + (! scsi_sense_is_deferred(&sshd))) {
Drop the space after '!' [from someone who loves to use spaces :]
--
~Randy
next prev parent reply other threads:[~2004-08-27 15:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-27 8:56 [PATCH] normalize fixed and descriptor sense data Douglas Gilbert
2004-08-27 15:18 ` Christoph Hellwig
2004-08-27 15:45 ` Luben Tuikov
2004-08-27 15:52 ` Christoph Hellwig
2004-08-27 15:46 ` Randy.Dunlap [this message]
2004-08-28 5:05 ` Douglas Gilbert
2004-08-28 20:23 ` Christoph Hellwig
2004-08-29 0:36 ` Douglas Gilbert
2004-08-29 8:59 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2004-08-27 14:56 Pat LaVarre
2004-08-28 4:07 ` Douglas Gilbert
2004-08-28 6:31 ` Kai Makisara
[not found] ` <3CC78E D C-FAAA-11D8-85F1-00039398BB5E@ieee.org>
2004-08-30 17:30 ` Pat LaVarre
2004-08-30 19:51 ` Kai Makisara
2004-08-30 20:03 ` Pat LaVarre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040827084605.40eebd63.rddunlap@osdl.org \
--to=rddunlap@osdl.org \
--cc=dougg@torque.net \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.