From: Christoph Hellwig <hch@infradead.org>
To: Luben Tuikov <luben_tuikov@adaptec.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Douglas Gilbert <dougg@torque.net>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] normalize fixed and descriptor sense data
Date: Fri, 27 Aug 2004 16:52:44 +0100 [thread overview]
Message-ID: <20040827165244.A32542@infradead.org> (raw)
In-Reply-To: <412F571A.8040607@adaptec.com>; from luben_tuikov@adaptec.com on Fri, Aug 27, 2004 at 11:45:30AM -0400
On Fri, Aug 27, 2004 at 11:45:30AM -0400, Luben Tuikov wrote:
> Christoph Hellwig wrote:
> >
> > +struct scsi_sense_hd { /* See SPC-3 section 4.5 */
> >
> > maybe scsi_sense_desc insted?
>
> Why, when it's neither in descriptor format nor in fixed
> format?
>
> It is just a header of the _consolidated_ format
> of the sense data, thus the name used makes sense.
Umm, right, makes sense. the _hd postfix still looks strange to me.
Either _hdr as standard short-notation for header or even better just
remove it.
> > Also I think this function should get a __ prefix and we should
> > add two small helpers that take a scsi_cmnd/scsi_request and use
> > the sense_buffer and len from it.
>
> But it should be exported nevertheless, as LLDDs may like
> to use it.
Makes sense.
next prev parent reply other threads:[~2004-08-27 15:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-27 8:56 [PATCH] normalize fixed and descriptor sense data Douglas Gilbert
2004-08-27 15:18 ` Christoph Hellwig
2004-08-27 15:45 ` Luben Tuikov
2004-08-27 15:52 ` Christoph Hellwig [this message]
2004-08-27 15:46 ` Randy.Dunlap
2004-08-28 5:05 ` Douglas Gilbert
2004-08-28 20:23 ` Christoph Hellwig
2004-08-29 0:36 ` Douglas Gilbert
2004-08-29 8:59 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2004-08-27 14:56 Pat LaVarre
2004-08-28 4:07 ` Douglas Gilbert
2004-08-28 6:31 ` Kai Makisara
[not found] ` <3CC78E D C-FAAA-11D8-85F1-00039398BB5E@ieee.org>
2004-08-30 17:30 ` Pat LaVarre
2004-08-30 19:51 ` Kai Makisara
2004-08-30 20:03 ` Pat LaVarre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040827165244.A32542@infradead.org \
--to=hch@infradead.org \
--cc=dougg@torque.net \
--cc=linux-scsi@vger.kernel.org \
--cc=luben_tuikov@adaptec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.