All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yoshinori K. Okuji" <okuji@enbug.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: JFS support (PATCH) and filesystem improvements
Date: Mon, 30 Aug 2004 12:22:55 +0200	[thread overview]
Message-ID: <200408301222.55861.okuji@enbug.org> (raw)
In-Reply-To: <87zn4f17fl.fsf@marco.marco-g.com>

On Saturday 28 August 2004 19:47, Marco Gerards wrote:
> Committed.

Thank you.

> And here is a patch for that.
>
> To avoid code duplication I wrote kern/fshelp.c, which has the
> following two functions:

That is a good idea, but why are the functions in the kernel? Imagine 
that GRUB 2 supports TFTP and the user uses GRUB as a network-based 
loader. Probably the user does not have to compile the helper 
functions, because network-based filesystems are very different at the 
implementation level.

So I think they should be in a module rather than the kernel. fshelp.mod 
sounds good for me.

Okuji



  parent reply	other threads:[~2004-08-30 10:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-23 12:48 JFS support (PATCH) and filesystem improvements Marco Gerards
2004-08-28 17:47 ` Marco Gerards
2004-08-29 23:00   ` Tomas Ebenlendr
2004-09-09 21:02     ` Marco Gerards
2004-09-10 18:06       ` Yoshinori K. Okuji
2004-08-30 10:22   ` Yoshinori K. Okuji [this message]
2004-08-30 15:49     ` Marco Gerards
2004-08-31 15:23       ` Tomas Ebenlendr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200408301222.55861.okuji@enbug.org \
    --to=okuji@enbug.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.