* [Ocfs2-devel] 2.6 I/O path totally messed up
@ 2004-08-30 8:50 Christoph Hellwig
2004-08-30 11:10 ` Mark Fasheh
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2004-08-30 8:50 UTC (permalink / raw)
To: ocfs2-devel
The second argumentto generic_file_write_nolock is an iovec, not an
actual userbuffer. The current code doesn't even have the slightest
chance to work. Maybe it's time to decouple the 2.6 read/write code
from the 2.4 code and implement proper vectored operations everywhere?
(and kill tge O_DIRECT vs O_APPEN hack, and the broken fallback code,
and..)
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Ocfs2-devel] 2.6 I/O path totally messed up
2004-08-30 8:50 [Ocfs2-devel] 2.6 I/O path totally messed up Christoph Hellwig
@ 2004-08-30 11:10 ` Mark Fasheh
0 siblings, 0 replies; 2+ messages in thread
From: Mark Fasheh @ 2004-08-30 11:10 UTC (permalink / raw)
To: ocfs2-devel
On Mon, Aug 30, 2004 at 03:50:22PM +0200, Christoph Hellwig wrote:
> The second argumentto generic_file_write_nolock is an iovec, not an
> actual userbuffer. The current code doesn't even have the slightest
> chance to work.
Yeah, I'm embarrassed to say we missed that in the commit for that code.
I'll be fixing it up asap.
> Maybe it's time to decouple the 2.6 read/write code
> from the 2.4 code and implement proper vectored operations everywhere?
Probably - we've got limited resources, so patches are welcome :)
> (and kill tge O_DIRECT vs O_APPEN hack, and the broken fallback code,
> and..)
No comment :)
--Mark
--
Mark Fasheh
Software Developer, Oracle Corp
mark.fasheh@oracle.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-08-30 11:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-08-30 8:50 [Ocfs2-devel] 2.6 I/O path totally messed up Christoph Hellwig
2004-08-30 11:10 ` Mark Fasheh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.