From: "David S. Miller" <davem@davemloft.net>
To: Brian Somers <brian.somers@sun.com>
Cc: Michael.Waychison@sun.com, linux-kernel@vger.kernel.org
Subject: Re: TG3 doesn't work in kernel 2.4.27 (David S. Miller)
Date: Mon, 30 Aug 2004 16:11:26 -0700 [thread overview]
Message-ID: <20040830161126.585a6b62.davem@davemloft.net> (raw)
In-Reply-To: <412DC055.4070401@sun.com>
Michael Chan at Broadcom spotted the bug.
Things are totally broken if the switch/hub does not support
autonegotiation. Checking for the MAC_STATUS_SIGNAL_DET bit
in the tg3 polling timer fixes the problem.
This is probably why it worked for you and doesn't with the
IBM blades as blades are more likely to be connected to
non-autoneg'ing devices.
===== drivers/net/tg3.c 1.199 vs edited =====
--- 1.199/drivers/net/tg3.c 2004-08-18 19:52:35 -07:00
+++ edited/drivers/net/tg3.c 2004-08-30 15:08:07 -07:00
@@ -5602,7 +5602,8 @@
need_setup = 1;
}
if (! netif_carrier_ok(tp->dev) &&
- (mac_stat & MAC_STATUS_PCS_SYNCED)) {
+ (mac_stat & (MAC_STATUS_PCS_SYNCED |
+ MAC_STATUS_SIGNAL_DET))) {
need_setup = 1;
}
if (need_setup) {
next prev parent reply other threads:[~2004-08-30 23:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040816110000.1120.31256.Mailman@lists.us.dell.com>
2004-08-16 11:51 ` TG3 doesn't work in kernel 2.4.27 (David S. Miller) Tetsuo Handa
2004-08-16 21:38 ` David S. Miller
2004-08-25 17:48 ` Mike Waychison
2004-08-25 19:08 ` David S. Miller
2004-08-25 20:04 ` Mike Waychison
2004-08-26 0:58 ` David S. Miller
2004-08-26 10:49 ` Brian Somers
2004-08-26 19:37 ` David S. Miller
2004-08-29 9:56 ` Pekka Pietikainen
2004-09-10 12:35 ` Brian Somers
2004-09-10 19:40 ` Roland Dreier
2004-09-10 20:53 ` David S. Miller
2004-09-10 21:05 ` Roland Dreier
2004-09-10 21:45 ` David S. Miller
2004-09-10 22:14 ` Brian Somers
2004-08-30 23:11 ` David S. Miller [this message]
2004-09-03 19:12 ` Paul Larson
2004-09-03 19:19 ` Mike Waychison
2004-09-03 20:18 ` Roland Dreier
2004-09-03 20:30 ` David S. Miller
2004-09-03 20:40 ` Roland Dreier
2004-09-03 23:24 ` Roland Dreier
2004-09-07 18:33 ` Jake Moilanen
2004-09-07 19:52 ` Roland Dreier
2004-09-08 12:34 ` Jake Moilanen
2004-09-08 13:07 ` Anton Blanchard
2004-09-13 22:48 ` David S. Miller
2004-09-14 22:20 ` Mike Waychison
2004-09-14 22:36 ` David S. Miller
2004-09-14 22:58 ` Jake Moilanen
2004-09-15 0:34 ` Roland Dreier
2004-09-08 13:55 ` Paul Larson
2004-09-10 16:00 ` Paul Larson
2004-09-03 20:08 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040830161126.585a6b62.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Michael.Waychison@sun.com \
--cc=brian.somers@sun.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.