Re: TG3 doesn't work in kernel 2.4.27 (David S. Miller)

[Mike Waychison <Michael.Waychison@Sun.COM>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

David S. Miller wrote:
> On Mon, 16 Aug 2004 20:51:03 +0900
> Tetsuo Handa <a5497108@anet.ne.jp> wrote:
>
>
>> From 2.4.26 till 2.4.27-rc3 were all OK.
>>This trouble happens with 2.4.27-rc4 and later.
>
>
> It's Sun's buggy 5704 Fiber auto-negotiation changes.
>
> Here is a hacky possible fix, can you try it?

Tetsuo posted his lscpi -vv output and he has an A2.  The hardware
autoneg patch was written and tested against an A3.

Would it make sense to do (hand-edited):



===== drivers/net/tg3.c 1.190 vs edited =====
- --- 1.190/drivers/net/tg3.c	2004-07-21 14:14:20 -07:00
+++ edited/drivers/net/tg3.c	2004-08-16 14:24:53 -07:00
@@ -5266,6 +5266,7 @@
 	tw32_f(MAC_LOW_WMARK_MAX_RX_FRAME, 2);

 	if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5704 &&
+	    tp->pci_chip_rev_id == CHIPREV_ID_5704_A3 &&
 	    tp->phy_id == PHY_ID_SERDES) {
 		/* Enable hardware link auto-negotiation */
 		u32 digctrl, txctrl;


- --
Mike Waychison
Sun Microsystems, Inc.
1 (650) 352-5299 voice
1 (416) 202-8336 voice
http://www.sun.com

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
NOTICE:  The opinions expressed in this email are held by me,
and may not represent the views of Sun Microsystems, Inc.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBLNEBdQs4kOxk3/MRAm0rAJwKKfpzuy3EoJuujODZwHPyg8oD/wCfTGiH
Xg4pbO71QGfZFKXGEkJH/IA=
=PA+X
-----END PGP SIGNATURE-----