All of lore.kernel.org
 help / color / mirror / Atom feed
From: maximilian attems <janitor@sternwelten.at>
To: Margit Schubert-While <margitsw@t-online.de>
Cc: netdev@oss.sgi.com, kj <kernel-janitors@osdl.org>
Subject: [Kernel-janitors] Re: [patch 8/8] prism54/islpci_dev: replace
Date: Thu, 02 Sep 2004 10:03:22 +0000	[thread overview]
Message-ID: <20040902100322.GD1876@stro.at> (raw)
In-Reply-To: <200409021135.57632.margitsw@t-online.de>

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

On Thu, 02 Sep 2004, Margit Schubert-While wrote:

> On Thu, 02 Sep 2004, Maximilian scribeth:
> > it shouldn't hinder 2.6 in it's progression.
> I consider this a regression.
> As schedule_timeout is used elesewhere in the prism54 code,
> we are using a consistent and documented method.

you didn't answer to the unit argument in favour of msleep.

shure msleep is also consistent and documented.

--
maks
kernel janitor  	http://janitor.kernelnewbies.org/


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: maximilian attems <janitor@sternwelten.at>
To: Margit Schubert-While <margitsw@t-online.de>
Cc: netdev@oss.sgi.com, kj <kernel-janitors@osdl.org>
Subject: Re: [patch 8/8]  prism54/islpci_dev: replace schedule_timeout() with msleep()
Date: Thu, 2 Sep 2004 12:03:22 +0200	[thread overview]
Message-ID: <20040902100322.GD1876@stro.at> (raw)
In-Reply-To: <200409021135.57632.margitsw@t-online.de>

On Thu, 02 Sep 2004, Margit Schubert-While wrote:

> On Thu, 02 Sep 2004, Maximilian scribeth:
> > it shouldn't hinder 2.6 in it's progression.
> I consider this a regression.
> As schedule_timeout is used elesewhere in the prism54 code,
> we are using a consistent and documented method.

you didn't answer to the unit argument in favour of msleep.

shure msleep is also consistent and documented.

--
maks
kernel janitor  	http://janitor.kernelnewbies.org/

  reply	other threads:[~2004-09-02 10:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-02  9:35 [patch 8/8] prism54/islpci_dev: replace schedule_timeout() with msleep() Margit Schubert-While
2004-09-02 10:03 ` maximilian attems [this message]
2004-09-02 10:03   ` maximilian attems
2004-09-02 16:23   ` [Kernel-janitors] Re: [patch 8/8] prism54/islpci_dev: replace Nishanth Aravamudan
2004-09-02 16:23     ` [Kernel-janitors] Re: [patch 8/8] prism54/islpci_dev: replace schedule_timeout() with msleep() Nishanth Aravamudan
  -- strict thread matches above, loose matches on Subject: below --
2004-09-02  6:50 Margit Schubert-While
2004-09-02  8:24 ` [Kernel-janitors] Re: [patch 8/8] prism54/islpci_dev: replace maximilian attems
2004-09-02 16:09   ` Nishanth Aravamudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040902100322.GD1876@stro.at \
    --to=janitor@sternwelten.at \
    --cc=kernel-janitors@osdl.org \
    --cc=margitsw@t-online.de \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.