Re: [PATCH 2.6] watch64: generic variable monitoring system

[Jeff Sipek <jeffpc@optonline.net>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 03 September 2004 15:16, you wrote:
> - Seems like a big interface for a simple problem.

I agree that the interface could be simplified a lot, however I decided to 
make it as generic as possible so that any part of the kernel can use it. I 
also am contemplating whether it would make sense to remove the capability of 
setting the interval to any value, and just have all variables checked every 
WATCH64_INTERVAL.

> - Code doesn't match the kernel style (read Documentation/CodingStyle)

Agreed. I'm going submit a correction patch.

> - Does it really need RCU and seqlock, wouldn't one suffice

As far as I can tell, it does. RCU to protect the linked list, and seqlock to 
protect the internal 64-bit counter.

Jeff.
- -- 
Research, n.:
  Consider Columbus:
    He didn't know where he was going.
    When he got there he didn't know where he was.
    When he got back he didn't know where he had been.
    And he did it all on someone else's money.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFBONGlwFP0+seVj/4RAlAFAJ9OiipyTpCGljodcwYgDSlXaWB3LACgnWLk
ZZLfkwnTFdsihHvTmfR+AuA=
=g5hE
-----END PGP SIGNATURE-----