All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Sipek <jeffpc@optonline.net>
To: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
Cc: netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6] watch64: generic variable monitoring system
Date: Fri, 03 Sep 2004 16:24:15 -0400	[thread overview]
Message-ID: <200409031624.22665.jeffpc@optonline.net> (raw)
In-Reply-To: <20040904.040727.72671952.yoshfuji@linux-ipv6.org>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 03 September 2004 15:07, YOSHIFUJI Hideaki / 吉藤英明 wrote:
> I agree with the basic principle; it is very similar to mine.

Yes, I saw a patch on lkml a while a go (possibly yours?) that used a 
workqueue (IIRC.)

> However, it is too complicated isn't it?

I considered the option of removing the capability of the programmer asking 
for a certain interval, and instead having all the variables checked every 
WATCH64_INTERVAL. 

> I would do per-"table" registration (instead of per-variable one);

I considered that option, but then decided to make the watch64 system generic 
enough so that it could be used from anywhere in the kernel. Is my idea of 
having a kernel-wide subsystem like this too heavy-weight?

> watch64_getval() seems very ugly to me...

How so? Is it the multiplicity of "if (!st)"?

Jeff.

- -- 
bad pun of the week: the formula 1 control computer suffered from a race 
condition
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFBONLzwFP0+seVj/4RAvYsAKCdVy9EzivcGtwa9CDiuvy/nwWuJwCglQ4L
iIf4QXC7PA+YwQs3905sRv0=
=NkA4
-----END PGP SIGNATURE-----

  reply	other threads:[~2004-09-03 20:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-03 17:06 [PATCH/RFC 2.6] NET: 64-bit network statistics josef Jeff Sipek
2004-09-03 17:19 ` [PATCH 2.6] watch64: generic variable monitoring system Josef 'Jeff' Sipek
2004-09-03 19:07   ` YOSHIFUJI Hideaki / 吉藤英明
2004-09-03 20:24     ` Jeff Sipek [this message]
2004-09-03 19:16   ` Stephen Hemminger
2004-09-03 20:18     ` Jeff Sipek
2004-09-03 20:40       ` Josef 'Jeff' Sipek
2004-09-03 21:44     ` Josef 'Jeff' Sipek
2004-09-04 13:19       ` jamal
2004-09-05 16:19         ` Jeff Sipek
2004-09-07 10:18           ` jamal
2004-09-12 15:53             ` Jeff Sipek
2004-09-03 17:22 ` [PATCH 2.6] 64network: 64-bit network statistics Josef 'Jeff' Sipek
2004-09-03 17:24 ` [PATCH/RFC 2.6] NET: " Jeff Sipek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200409031624.22665.jeffpc@optonline.net \
    --to=jeffpc@optonline.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.