All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Antonino A. Daplas" <adaplas@hotpop.com>
To: Thomas Winischhofer <thomas@winischhofer.net>, adaplas@pol.net
Cc: Andrew Morton <akpm@osdl.org>,
	Linux Fbdev development list
	<linux-fbdev-devel@lists.sourceforge.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5][RFC] fbdev: Clean up framebuffer initialization
Date: Sat, 4 Sep 2004 14:53:01 +0800	[thread overview]
Message-ID: <200409041453.01644.adaplas@hotpop.com> (raw)
In-Reply-To: <41393829.6020302@winischhofer.net>

On Saturday 04 September 2004 11:36, Thomas Winischhofer wrote:
> > 5. Because driver initialization will be dependent on the link order,
> > hardware that depends on other subsystems (agpgart, usb, serial, etc) may
> > choose to initialize after the subsystems they depend on.
> >
> > Signed-off-by: Antonino Daplas <adaplas@pol.net>
>
> I don't really see a benefit but it's ok with me.
>

Mainly cleanup, but also point #5.  The i810fb, for instance, depends on agpgart, but
agpgart gets initialized way after fbdev.  The workaround is for i810fb to explicitly
call intel_agp_init().  Besides the ugliness, forcibly initializing the agpgart subsystem
out of sequence may cause problems.

With this change, in theory, I can move i810fb's link order so it gets initialized after
agpgart.

> (Thanks for considering the "unified" nature of sisfb, by the way. Very
> considarate. Very much appreciated.)
>
> I assume that you tested this stuff before posting it here.

Yes, with hardware that I have.  I did try to at least compile test what I can.

Tony




-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click

WARNING: multiple messages have this Message-ID (diff)
From: "Antonino A. Daplas" <adaplas@hotpop.com>
To: Thomas Winischhofer <thomas@winischhofer.net>, adaplas@pol.net
Cc: Andrew Morton <akpm@osdl.org>,
	Linux Fbdev development list 
	<linux-fbdev-devel@lists.sourceforge.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5][RFC] fbdev: Clean up framebuffer initialization
Date: Sat, 4 Sep 2004 14:53:01 +0800	[thread overview]
Message-ID: <200409041453.01644.adaplas@hotpop.com> (raw)
In-Reply-To: <41393829.6020302@winischhofer.net>

On Saturday 04 September 2004 11:36, Thomas Winischhofer wrote:
> > 5. Because driver initialization will be dependent on the link order,
> > hardware that depends on other subsystems (agpgart, usb, serial, etc) may
> > choose to initialize after the subsystems they depend on.
> >
> > Signed-off-by: Antonino Daplas <adaplas@pol.net>
>
> I don't really see a benefit but it's ok with me.
>

Mainly cleanup, but also point #5.  The i810fb, for instance, depends on agpgart, but
agpgart gets initialized way after fbdev.  The workaround is for i810fb to explicitly
call intel_agp_init().  Besides the ugliness, forcibly initializing the agpgart subsystem
out of sequence may cause problems.

With this change, in theory, I can move i810fb's link order so it gets initialized after
agpgart.

> (Thanks for considering the "unified" nature of sisfb, by the way. Very
> considarate. Very much appreciated.)
>
> I assume that you tested this stuff before posting it here.

Yes, with hardware that I have.  I did try to at least compile test what I can.

Tony



  reply	other threads:[~2004-09-04  6:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-04  3:08 [PATCH 4/5][RFC] fbdev: Clean up framebuffer initialization Antonino A. Daplas
2004-09-04  3:08 ` Antonino A. Daplas
2004-09-04  3:36 ` Thomas Winischhofer
2004-09-04  6:53   ` Antonino A. Daplas [this message]
2004-09-04  6:53     ` Antonino A. Daplas
2004-09-04  7:46     ` Otto Wyss
2004-09-04 12:37       ` Antonino A. Daplas
2004-09-05  9:16 ` Geert Uytterhoeven
2004-09-05  9:16   ` [Linux-fbdev-devel] " Geert Uytterhoeven
2004-09-05  9:50   ` Antonino A. Daplas
2004-09-05 10:13     ` Geert Uytterhoeven
2004-09-05 10:40       ` Antonino A. Daplas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200409041453.01644.adaplas@hotpop.com \
    --to=adaplas@hotpop.com \
    --cc=adaplas@pol.net \
    --cc=akpm@osdl.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thomas@winischhofer.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.