Re: [PATCH] netpoll endian fixes

[Matt Mackall <mpm@selenic.com>]

On Wed, Sep 08, 2004 at 01:24:43AM +0200, Duncan Sands wrote:
> The big-endians took their revenge in netpoll.c: on i386,
> the ip header length / version nibbles need to be the other
> way round; and the htonl leaves only zeros in tot_len...
> 
> All the best, 
> 
> Duncan.
> 
> 
> --- linux-2.5/net/core/netpoll.c.orig	2004-09-08 01:15:22.000000000 +0200
> +++ linux-2.5/net/core/netpoll.c	2004-09-08 01:05:33.000000000 +0200
> @@ -22,6 +22,7 @@
>  #include <net/tcp.h>
>  #include <net/udp.h>
>  #include <asm/unaligned.h>
> +#include <asm/byteorder.h>
>  
>  /*
>   * We maintain a small pool of fully-sized skbs, to make sure the
> @@ -242,9 +243,13 @@
>  	iph = (struct iphdr *)skb_push(skb, sizeof(*iph));
>  
>  	/* iph->version = 4; iph->ihl = 5; */
> +#if defined(__LITTLE_ENDIAN_BITFIELD)
> +	put_unaligned(0x45, (unsigned char *)iph);
> +#else
>  	put_unaligned(0x54, (unsigned char *)iph);
> +#endif

Probably what's happened is this:

The original person who sent me the alignment fixes sent a similar
bizarre endian #ifdef thing. He didn't send it as a proper patch
though, so I redid it and copied the not-so-obviously incorrect
clause.

It looks like it ought to be 0x45 everywhere, meaning it's currently
broken everywhere. But no one's complained. Unfortunately at the
present moment I've got one machine short of a test rig unpacked, so
I'm loathe to push another fix until I get some other test reports.
Anyone else run into trouble with netpoll/netconsole in recent -mm or
-bk?

-- 
Mathematics is the supreme nostalgia of our time.