All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: blaisorblade_spam@yahoo.it
Cc: akpm@osdl.org, jdike@addtoit.com, linux-kernel@vger.kernel.org,
	user-mode-linux-devel@lists.sourceforge.net
Subject: [uml-devel] Re: [patch 2/3] uml-ubd-any-elevator
Date: Wed, 8 Sep 2004 11:23:14 +0200	[thread overview]
Message-ID: <20040908092314.GE2258@suse.de> (raw)
In-Reply-To: <20040906174449.8CAAEBB1A@zion.localdomain>

On Mon, Sep 06 2004, blaisorblade_spam@yahoo.it wrote:
> diff -puN arch/um/drivers/ubd_kern.c~uml-ubd-any-elevator arch/um/drivers/ubd_kern.c
> --- uml-linux-2.6.8.1/arch/um/drivers/ubd_kern.c~uml-ubd-any-elevator	2004-08-29 14:40:53.731043416 +0200
> +++ uml-linux-2.6.8.1-paolo/arch/um/drivers/ubd_kern.c	2004-08-29 14:40:53.733043112 +0200
> @@ -749,8 +749,6 @@ int ubd_init(void)
>  		return -1;
>  	}
>  		
> -	elevator_init(ubd_queue, &elevator_noop);
> -
>  	if (fake_major != MAJOR_NR) {
>  		char name[sizeof("ubd_nnn\0")];

if this is not applied, at least the file needs an elevator_exit(q);
before calling elevator_init() for the new elevator. otherwise the
original elevator data is leaked.

-- 
Jens Axboe



-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@suse.de>
To: blaisorblade_spam@yahoo.it
Cc: akpm@osdl.org, jdike@addtoit.com, linux-kernel@vger.kernel.org,
	user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [patch 2/3] uml-ubd-any-elevator
Date: Wed, 8 Sep 2004 11:23:14 +0200	[thread overview]
Message-ID: <20040908092314.GE2258@suse.de> (raw)
In-Reply-To: <20040906174449.8CAAEBB1A@zion.localdomain>

On Mon, Sep 06 2004, blaisorblade_spam@yahoo.it wrote:
> diff -puN arch/um/drivers/ubd_kern.c~uml-ubd-any-elevator arch/um/drivers/ubd_kern.c
> --- uml-linux-2.6.8.1/arch/um/drivers/ubd_kern.c~uml-ubd-any-elevator	2004-08-29 14:40:53.731043416 +0200
> +++ uml-linux-2.6.8.1-paolo/arch/um/drivers/ubd_kern.c	2004-08-29 14:40:53.733043112 +0200
> @@ -749,8 +749,6 @@ int ubd_init(void)
>  		return -1;
>  	}
>  		
> -	elevator_init(ubd_queue, &elevator_noop);
> -
>  	if (fake_major != MAJOR_NR) {
>  		char name[sizeof("ubd_nnn\0")];

if this is not applied, at least the file needs an elevator_exit(q);
before calling elevator_init() for the new elevator. otherwise the
original elevator data is leaked.

-- 
Jens Axboe


  reply	other threads:[~2004-09-08  9:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-06 17:44 [uml-devel] [patch 2/3] uml-ubd-any-elevator blaisorblade_spam
2004-09-06 17:44 ` blaisorblade_spam
2004-09-08  9:23 ` Jens Axboe [this message]
2004-09-08  9:23   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040908092314.GE2258@suse.de \
    --to=axboe@suse.de \
    --cc=akpm@osdl.org \
    --cc=blaisorblade_spam@yahoo.it \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.