All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] RFC - compile iptables without O2
@ 2004-09-08 22:34 Phil Oester
  0 siblings, 0 replies; only message in thread
From: Phil Oester @ 2004-09-08 22:34 UTC (permalink / raw)
  To: netfilter-devel

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

There is an ancient bug in bugzilla (#13) which says iptables should 
compile without 'O2'.  Not sure why this is important, but the below
patch makes it compile, and the resulting executable works.

Anyone comment on why these '#ifndef __OPTIMIZE' statements were added
in the first place, and whether I'm missing something by simply removing
them?

Phil



[-- Attachment #2: patch-nooptimize --]
[-- Type: text/plain, Size: 1398 bytes --]

diff -ru ipt-orig/ip6tables.c ipt-new/ip6tables.c
--- ipt-orig/ip6tables.c	2004-06-14 18:02:16.000000000 -0400
+++ ipt-new/ip6tables.c	2004-09-08 18:14:53.031881136 -0400
@@ -148,14 +148,6 @@
  * magic number of -1 */
 int line = -1;
 
-#ifndef __OPTIMIZE__
-struct ip6t_entry_target *
-ip6t_get_target(struct ip6t_entry *e)
-{
-	return (void *)e + e->target_offset;
-}
-#endif
-
 static struct option *opts = original_opts;
 static unsigned int global_option_offset = 0;
 
diff -ru ipt-orig/iptables.c ipt-new/iptables.c
--- ipt-orig/iptables.c	2004-06-14 18:02:16.000000000 -0400
+++ ipt-new/iptables.c	2004-09-08 18:14:23.430381248 -0400
@@ -147,14 +147,6 @@
  * magic number of -1 */
 int line = -1;
 
-#ifndef __OPTIMIZE__
-struct ipt_entry_target *
-ipt_get_target(struct ipt_entry *e)
-{
-	return (void *)e + e->target_offset;
-}
-#endif
-
 static struct option *opts = original_opts;
 static unsigned int global_option_offset = 0;
 
diff -ru ipt-orig/libiptc/libiptc.c ipt-new/libiptc/libiptc.c
--- ipt-orig/libiptc/libiptc.c	2004-06-14 18:02:18.000000000 -0400
+++ ipt-new/libiptc/libiptc.c	2004-09-08 18:19:36.847734568 -0400
@@ -27,14 +27,6 @@
 #define IPT_LIB_DIR "/usr/local/lib/iptables"
 #endif
 
-#ifndef __OPTIMIZE__
-STRUCT_ENTRY_TARGET *
-GET_TARGET(STRUCT_ENTRY *e)
-{
-	return (void *)e + e->target_offset;
-}
-#endif
-
 static int sockfd = -1;
 static void *iptc_fn = NULL;
 

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-09-08 22:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-08 22:34 [PATCH] RFC - compile iptables without O2 Phil Oester

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.