* [PATCH] document multiport invert option
@ 2004-09-08 23:35 Phil Oester
2004-09-09 10:07 ` Martin Josefsson
0 siblings, 1 reply; 3+ messages in thread
From: Phil Oester @ 2004-09-08 23:35 UTC (permalink / raw)
To: netfilter-devel
[-- Attachment #1: Type: text/plain, Size: 207 bytes --]
The man/-h pages for multiport don't document that you can use
inversion. This can be confusing, since multiport uses '! --port x'
instead of '--dport ! x' like tcp/udp.
This closes bugzilla #143
Phil
[-- Attachment #2: patch-notmultiport --]
[-- Type: text/plain, Size: 5471 bytes --]
diff -ru ipt-orig/extensions/libip6t_multiport.c ipt-new/extensions/libip6t_multiport.c
--- ipt-orig/extensions/libip6t_multiport.c 2003-07-14 16:01:29.000000000 -0400
+++ ipt-new/extensions/libip6t_multiport.c 2004-09-08 19:29:59.897221576 -0400
@@ -13,13 +13,13 @@
{
printf(
"multiport v%s options:\n"
-" --source-ports port[,port,port...]\n"
-" --sports ...\n"
+" [!] --source-ports port[,port,port...]\n"
+" [!] --sports ...\n"
" match source port(s)\n"
-" --destination-ports port[,port,port...]\n"
-" --dports ...\n"
+" [!] --destination-ports port[,port,port...]\n"
+" [!] --dports ...\n"
" match destination port(s)\n"
-" --ports port[,port,port]\n"
+" [!] --ports port[,port,port]\n"
" match both source and destination port(s)\n",
IPTABLES_VERSION);
}
diff -ru ipt-orig/extensions/libip6t_multiport.man ipt-new/extensions/libip6t_multiport.man
--- ipt-orig/extensions/libip6t_multiport.man 2004-01-22 10:04:24.000000000 -0500
+++ ipt-new/extensions/libip6t_multiport.man 2004-09-08 19:24:43.199366968 -0400
@@ -4,16 +4,16 @@
or
.BR "-p udp" .
.TP
-.BR "--source-ports " "\fIport\fP[,\fIport\fP[,\fIport\fP...]]"
+.BR "[!] --source-ports " "\fIport\fP[,\fIport\fP[,\fIport\fP...]]"
Match if the source port is one of the given ports. The flag
.B --sports
is a convenient alias for this option.
.TP
-.BR "--destination-ports " "\fIport\fP[,\fIport\fP[,\fIport\fP...]]"
+.BR "[!] --destination-ports " "\fIport\fP[,\fIport\fP[,\fIport\fP...]]"
Match if the destination port is one of the given ports. The flag
.B --dports
is a convenient alias for this option.
.TP
-.BR "--ports " "\fIport\fP[,\fIport\fP[,\fIport\fP...]]"
+.BR "[!] --ports " "\fIport\fP[,\fIport\fP[,\fIport\fP...]]"
Match if the both the source and destination ports are equal to each
other and to one of the given ports.
diff -ru ipt-orig/extensions/libipt_mport.c ipt-new/extensions/libipt_mport.c
--- ipt-orig/extensions/libipt_mport.c 2003-07-14 16:01:29.000000000 -0400
+++ ipt-new/extensions/libipt_mport.c 2004-09-08 19:30:26.468182176 -0400
@@ -13,13 +13,13 @@
{
printf(
"mport v%s options:\n"
-" --source-ports port[,port:port,port...]\n"
-" --sports ...\n"
+" [!] --source-ports port[,port:port,port...]\n"
+" [!] --sports ...\n"
" match source port(s)\n"
-" --destination-ports port[,port:port,port...]\n"
-" --dports ...\n"
+" [!] --destination-ports port[,port:port,port...]\n"
+" [!] --dports ...\n"
" match destination port(s)\n"
-" --ports port[,port:port,port]\n"
+" [!] --ports port[,port:port,port]\n"
" match both source and destination port(s)\n",
IPTABLES_VERSION);
}
diff -ru ipt-orig/extensions/libipt_mport.man ipt-new/extensions/libipt_mport.man
--- ipt-orig/extensions/libipt_mport.man 2004-01-22 10:04:25.000000000 -0500
+++ ipt-new/extensions/libipt_mport.man 2004-09-08 19:24:08.047710832 -0400
@@ -4,16 +4,16 @@
or
.BR "-p udp" .
.TP
-.BR "--source-ports " "\fIport\fP[,\fIport\fP[,\fIport\fP...]]"
+.BR "[!] --source-ports " "\fIport\fP[,\fIport\fP[,\fIport\fP...]]"
Match if the source port is one of the given ports. The flag
.B --sports
is a convenient alias for this option.
.TP
-.BR "--destination-ports " "\fIport\fP[,\fIport\fP[,\fIport\fP...]]"
+.BR "[!] --destination-ports " "\fIport\fP[,\fIport\fP[,\fIport\fP...]]"
Match if the destination port is one of the given ports. The flag
.B --dports
is a convenient alias for this option.
.TP
-.BR "--ports " "\fIport\fP[,\fIport\fP[,\fIport\fP...]]"
+.BR "[!] --ports " "\fIport\fP[,\fIport\fP[,\fIport\fP...]]"
Match if the both the source and destination ports are equal to each
other and to one of the given ports.
diff -ru ipt-orig/extensions/libipt_multiport.c ipt-new/extensions/libipt_multiport.c
--- ipt-orig/extensions/libipt_multiport.c 2003-07-14 16:01:29.000000000 -0400
+++ ipt-new/extensions/libipt_multiport.c 2004-09-08 19:30:47.800939104 -0400
@@ -13,13 +13,13 @@
{
printf(
"multiport v%s options:\n"
-" --source-ports port[,port,port...]\n"
-" --sports ...\n"
+" [!] --source-ports port[,port,port...]\n"
+" [!] --sports ...\n"
" match source port(s)\n"
-" --destination-ports port[,port,port...]\n"
-" --dports ...\n"
+" [!] --destination-ports port[,port,port...]\n"
+" [!] --dports ...\n"
" match destination port(s)\n"
-" --ports port[,port,port]\n"
+" [!] --ports port[,port,port]\n"
" match both source and destination port(s)\n",
IPTABLES_VERSION);
}
diff -ru ipt-orig/extensions/libipt_multiport.man ipt-new/extensions/libipt_multiport.man
--- ipt-orig/extensions/libipt_multiport.man 2004-01-22 10:04:25.000000000 -0500
+++ ipt-new/extensions/libipt_multiport.man 2004-09-08 19:23:50.583365816 -0400
@@ -4,16 +4,16 @@
or
.BR "-p udp" .
.TP
-.BR "--source-ports " "\fIport\fP[,\fIport\fP[,\fIport\fP...]]"
+.BR "[!] --source-ports " "\fIport\fP[,\fIport\fP[,\fIport\fP...]]"
Match if the source port is one of the given ports. The flag
.B --sports
is a convenient alias for this option.
.TP
-.BR "--destination-ports " "\fIport\fP[,\fIport\fP[,\fIport\fP...]]"
+.BR "[!] --destination-ports " "\fIport\fP[,\fIport\fP[,\fIport\fP...]]"
Match if the destination port is one of the given ports. The flag
.B --dports
is a convenient alias for this option.
.TP
-.BR "--ports " "\fIport\fP[,\fIport\fP[,\fIport\fP...]]"
+.BR "[!] --ports " "\fIport\fP[,\fIport\fP[,\fIport\fP...]]"
Match if the both the source and destination ports are equal to each
other and to one of the given ports.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] document multiport invert option
2004-09-08 23:35 [PATCH] document multiport invert option Phil Oester
@ 2004-09-09 10:07 ` Martin Josefsson
2004-09-09 13:36 ` Herve Eychenne
0 siblings, 1 reply; 3+ messages in thread
From: Martin Josefsson @ 2004-09-09 10:07 UTC (permalink / raw)
To: Phil Oester; +Cc: netfilter-devel
[-- Attachment #1: Type: text/plain, Size: 468 bytes --]
On Thu, 2004-09-09 at 01:35, Phil Oester wrote:
> The man/-h pages for multiport don't document that you can use
> inversion. This can be confusing, since multiport uses '! --port x'
> instead of '--dport ! x' like tcp/udp.
>
> This closes bugzilla #143
I believe neither multiport or mport has invert support, they don't
complain when you add a inverted rule but the resulting rule won't be
inverted so I'm not going to apply this patch.
--
/Martin
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] document multiport invert option
2004-09-09 10:07 ` Martin Josefsson
@ 2004-09-09 13:36 ` Herve Eychenne
0 siblings, 0 replies; 3+ messages in thread
From: Herve Eychenne @ 2004-09-09 13:36 UTC (permalink / raw)
To: Martin Josefsson; +Cc: netfilter-devel
On Thu, Sep 09, 2004 at 12:07:23PM +0200, Martin Josefsson wrote:
> On Thu, 2004-09-09 at 01:35, Phil Oester wrote:
> > The man/-h pages for multiport don't document that you can use
> > inversion. This can be confusing, since multiport uses '! --port x'
> > instead of '--dport ! x' like tcp/udp.
> >
> > This closes bugzilla #143
> I believe neither multiport or mport has invert support, they don't
> complain when you add a inverted rule but the resulting rule won't be
> inverted so I'm not going to apply this patch.
Though, multiport and mport should have invert support, right?
So you may add this support to your patch, phil. :-)
Herve
--
_
(°= Hervé Eychenne
//)
v_/_ WallFire project: http://www.wallfire.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-09-09 13:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-08 23:35 [PATCH] document multiport invert option Phil Oester
2004-09-09 10:07 ` Martin Josefsson
2004-09-09 13:36 ` Herve Eychenne
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.