From: Tom Rini <trini@kernel.crashing.org>
To: Linus Torvalds <torvalds@osdl.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH 2.6.9-rc1-bk16] ppc32: Use $(addprefix ...) on arch/ppc/boot/lib/
Date: Thu, 9 Sep 2004 08:30:31 -0700 [thread overview]
Message-ID: <20040909153031.GA2945@smtp.west.cox.net> (raw)
The following makes arch/ppc/boot/lib/Makefile use $(addprefix ...) to
get lib/zlib_inflate/ source code. Previously we were manually setting
the dependancy and invoking cc_o_c. Worse, we were invoking the cmd
version, not the rule version and thus when MODVERSIONS=y, we wouldn't
do the .tmp_foo.o -> foo.o rename, and thus the compile would break.
Using $(addprefix ...) gets us using the standard rules again (and is
shorter to boot).
Signed-off-by: Tom Rini <trini@kernel.crashing.org>
--- 1.7/arch/ppc/boot/lib/Makefile 2004-09-07 23:33:06 -07:00
+++ edited/arch/ppc/boot/lib/Makefile 2004-09-09 08:26:23 -07:00
@@ -4,18 +4,8 @@
CFLAGS_kbd.o += -Idrivers/char
-$(obj)/infblock.o: lib/zlib_inflate/infblock.c
- $(call cmd,cc_o_c)
-$(obj)/infcodes.o: lib/zlib_inflate/infcodes.c
- $(call cmd,cc_o_c)
-$(obj)/inffast.o: lib/zlib_inflate/inffast.c
- $(call cmd,cc_o_c)
-$(obj)/inflate.o: lib/zlib_inflate/inflate.c
- $(call cmd,cc_o_c)
-$(obj)/inftrees.o: lib/zlib_inflate/inftrees.c
- $(call cmd,cc_o_c)
-$(obj)/infutil.o: lib/zlib_inflate/infutil.c
- $(call cmd,cc_o_c)
+INFLATE = $(addprefix ../../../../lib/zlib_inflate/, infblock.o \
+ infcodes.o inffast.o inflate.o inftrees.o infutil.o)
-lib-y := infblock.o infcodes.o inffast.o inflate.o inftrees.o infutil.o div64.o
+lib-y := $(INFLATE) div64.o
lib-$(CONFIG_VGA_CONSOLE) += vreset.o kbd.o
--
Tom Rini
http://gate.crashing.org/~trini/
next reply other threads:[~2004-09-09 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-09 15:30 Tom Rini [this message]
2004-09-09 16:37 ` [PATCH 2.6.9-rc1-bk16] ppc32: Use $(addprefix ...) on arch/ppc/boot/lib/ Sam Ravnborg
2004-09-09 17:06 ` Tom Rini
2004-09-11 16:29 ` Tom Rini
2004-09-11 18:25 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040909153031.GA2945@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.