From: Sam Ravnborg <sam@ravnborg.org>
To: Tom Rini <trini@kernel.crashing.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.6.9-rc1-bk16] ppc32: Use $(addprefix ...) on arch/ppc/boot/lib/
Date: Thu, 9 Sep 2004 18:37:05 +0200 [thread overview]
Message-ID: <20040909163705.GA7830@mars.ravnborg.org> (raw)
In-Reply-To: <20040909153031.GA2945@smtp.west.cox.net>
On Thu, Sep 09, 2004 at 08:30:31AM -0700, Tom Rini wrote:
> The following makes arch/ppc/boot/lib/Makefile use $(addprefix ...) to
> get lib/zlib_inflate/ source code. Previously we were manually setting
> the dependancy and invoking cc_o_c. Worse, we were invoking the cmd
> version, not the rule version and thus when MODVERSIONS=y, we wouldn't
> do the .tmp_foo.o -> foo.o rename, and thus the compile would break.
> Using $(addprefix ...) gets us using the standard rules again (and is
> shorter to boot).
Your patch was pending my comments - sorry.
Why not:
lib-y := $(addprefix lib/zlib_inflate/,infblock.o infcodes.o inffast.o \
inflate.o inftrees.o infutil.o)
lib-y += div64.o
lib-$(CONFIG_VGA_CONSOLE) += vreset.o kbd.o
No need to use that ugly relative path.
I do not like this way of selectng .o files. It will so
obviously break the build with make -j if there is no synchronisation
point. vmlinux provide this synchronisation point in this case.
But in this particular case I see no better alternative.
Sam
next prev parent reply other threads:[~2004-09-09 16:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-09 15:30 [PATCH 2.6.9-rc1-bk16] ppc32: Use $(addprefix ...) on arch/ppc/boot/lib/ Tom Rini
2004-09-09 16:37 ` Sam Ravnborg [this message]
2004-09-09 17:06 ` Tom Rini
2004-09-11 16:29 ` Tom Rini
2004-09-11 18:25 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040909163705.GA7830@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.