[Patch 2/6]: ext3 reservations: Renumber the ext3 reservations ioctls

[Patch 2/6]: ext3 reservations: Renumber the ext3 reservations ioctls

[Stephen Tweedie]

All ext2/3 ioctls apart from these ones use 'f' as the root char for
their macro-generated ioctl numbers; make reservations consistent with
this.

Signed-off-by: Stephen Tweedie <sct@redhat.com>

--- linux-2.6.9-rc1-mm4/include/linux/ext3_fs.h.=K0001=.orig
+++ linux-2.6.9-rc1-mm4/include/linux/ext3_fs.h
@@ -235,8 +235,8 @@ struct ext3_new_group_data {
 #ifdef CONFIG_JBD_DEBUG
 #define EXT3_IOC_WAIT_FOR_READONLY	_IOR('f', 99, long)
 #endif
-#define EXT3_IOC_GETRSVSZ		_IOR('r', 1, long)
-#define EXT3_IOC_SETRSVSZ		_IOW('r', 2, long)
+#define EXT3_IOC_GETRSVSZ		_IOR('f', 5, long)
+#define EXT3_IOC_SETRSVSZ		_IOW('f', 6, long)
 
 /*
  * Structure of an inode on the disk

Re: [Patch 2/6]: ext3 reservations: Renumber the ext3 reservations ioctls

[Christoph Hellwig]

On Tue, Sep 07, 2004 at 02:02:27PM +0100, Stephen Tweedie wrote:
> All ext2/3 ioctls apart from these ones use 'f' as the root char for
> their macro-generated ioctl numbers; make reservations consistent with
> this.

Maybe you could reuse the XFS reservation ioctls instead of adding
another set?  Having incompatible APIs for the same thing on different
filesystems sounds like the wrong way to go.

Re: [Patch 2/6]: ext3 reservations: Renumber the ext3 reservations ioctls

[Stephen C. Tweedie]

Hi,

On Tue, 2004-09-07 at 23:53, Christoph Hellwig wrote:

> Maybe you could reuse the XFS reservation ioctls instead of adding
> another set?  Having incompatible APIs for the same thing on different
> filesystems sounds like the wrong way to go.

I don't mind either way.  But I just looked, and I think they are doing
different things.  If I'm reading the XFS bits right, the XFS ioctls
actively reserve/free disk space; but the ext3 ones do nothing except
set/query the size of the per-inode sliding reservation window.

So sounds like they are best kept separate for now.

Cheers,
 Stephen

Re: [Patch 2/6]: ext3 reservations: Renumber the ext3 reservations ioctls

[Christoph Hellwig]

On Wed, Sep 08, 2004 at 10:41:38AM +0100, Stephen C. Tweedie wrote:
> Hi,
> 
> On Tue, 2004-09-07 at 23:53, Christoph Hellwig wrote:
> 
> > Maybe you could reuse the XFS reservation ioctls instead of adding
> > another set?  Having incompatible APIs for the same thing on different
> > filesystems sounds like the wrong way to go.
> 
> I don't mind either way.  But I just looked, and I think they are doing
> different things.  If I'm reading the XFS bits right, the XFS ioctls
> actively reserve/free disk space; but the ext3 ones do nothing except
> set/query the size of the per-inode sliding reservation window.
> 
> So sounds like they are best kept separate for now.

makes sense.