All of lore.kernel.org
 help / color / mirror / Atom feed
* swsusp: kill crash when too much memory is free
@ 2004-09-09 15:42 Pavel Machek
  2004-09-09 22:01 ` Rafael J. Wysocki
  0 siblings, 1 reply; 14+ messages in thread
From: Pavel Machek @ 2004-09-09 15:42 UTC (permalink / raw)
  To: kernel list, Andrew Morton, Patrick Mochel

Hi!

If too much memory is free, swsusp dies in quite a ugly way. Even when
it is not neccessary to relocate pagedir, it is proably still
neccessary to relocate individual pages. Thanks to Kurt Garloff and
Stefan Seyfried...
								Pavel
PS: And could I have one brown paper bag, please?

--- clean-mm/kernel/power/swsusp.c	2004-09-07 21:12:33.000000000 +0200
+++ linux-mm/kernel/power/swsusp.c	2004-09-09 08:56:20.000000000 +0200
@@ -950,9 +934,9 @@
 
 	printk("Relocating pagedir ");
 
-	if(!does_collide_order(old_pagedir, (unsigned long)old_pagedir, pagedir_order)) {
+	if (!does_collide_order(old_pagedir, (unsigned long)old_pagedir, pagedir_order)) {
 		printk("not necessary\n");
-		return 0;
+		return check_pagedir();
 	}
 
 	while ((m = (void *) __get_free_pages(GFP_ATOMIC, pagedir_order)) != NULL) {




^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2004-09-12 22:21 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-09 15:42 swsusp: kill crash when too much memory is free Pavel Machek
2004-09-09 22:01 ` Rafael J. Wysocki
2004-09-10  9:40   ` Pavel Machek
2004-09-10 10:45     ` Rafael J. Wysocki
2004-09-10 17:26     ` Rafael J. Wysocki
2004-09-10 22:29       ` Pavel Machek
2004-09-11  9:50         ` Rafael J. Wysocki
2004-09-11 19:22           ` Rafael J. Wysocki
2004-09-11 21:59             ` Rafael J. Wysocki
2004-09-12 10:32               ` swsusp (2.6.9-rc1-mm4 + bigdiff): Unable to handle kernel paging request Rafael J. Wysocki
2004-09-12 20:42           ` swsusp: kill crash when too much memory is free Pavel Machek
2004-09-12 21:16             ` Rafael J. Wysocki
2004-09-12 21:40               ` Stefan Seyfried
2004-09-12 22:23                 ` Rafael J. Wysocki

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.