Re: [uml-devel] [PATCH] nptl/sys_clone fix for i386/ppc

[Jeff Dike <jdike@addtoit.com>]

On Sun, Sep 12, 2004 at 05:52:44PM +0200, BlaisorBlade wrote:
> It worked no worse than current version (which is broken). In fact the 2.4 
> clone had 2 arguments. So it's obvious.

In fact, it worked better.  It worked on a modern Debian filesystem, where
my old code didn't.  Hence I didn't notice the mistake (although I should 
have compared what I did with David's patch and justified the differences,
if any).

> However, this is non-standard. I've added just a comment for now, since you 
> may have reason to keep the current code, but such behaviour calls for 
> breakage when things change.

Yeah, I not sure why I did things the way I did.  That's very old code, and
there may have been some good reason for it which has since disappeared.

Offhand, it looks like doing things in the standard way will clean up
copy_thread a bit.

				Jeff


-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM. 
Deadline: Sept. 13. Go here: http://sf.net/ppc_contest.php
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel