From: Herbert Poetzl <herbert@13thfloor.at>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
Andries Brouwer <Andries.Brouwer@cwi.nl>,
Andrew Morton <akpm@osdl.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [no patch] broken use of mm_release / deactivate_mm
Date: Tue, 14 Sep 2004 19:00:19 +0200 [thread overview]
Message-ID: <20040914170019.GA3580@MAIL.13thfloor.at> (raw)
In-Reply-To: <Pine.LNX.4.58.0409140803090.2378@ppc970.osdl.org>
On Tue, Sep 14, 2004 at 08:06:14AM -0700, Linus Torvalds wrote:
>
>
> On Tue, 14 Sep 2004, Nick Piggin wrote:
> > >
> > > I agree. Looks like the "exit_mm()" should really be a "mmput()".
> > >
> > > Can we have a few more eyes on this thing? Ingo, Nick?
> >
> > AFAIKS yes. exit_mm doesn't look legal unless its dropping the current
> > mm context. And mmput looks like it should clean up everything - it is
> > used almost exactly the same way to cleanup a failure case in copy_mm.
>
> Does everybody also agree that the
>
> if (p->active_mm)
> mmdrop(p->active_mm);
>
> should also be dropped, and that mmput() does all of that correctly too?
>
> (Again, looking at all the counts etc, I think the answer is a resounding
> yes, but dammit, this code has obviously never gotten any testing at all,
> since it effectively never happens).
IIRC, linux-vserver did hit it once or twice
but I wasn't sure at that time that it isn't my
fault ...
this 'error path' was used by the memory limiting
code, so it's probably easy to test with minor
adjustments ...
best,
Herbert
> Linus
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2004-09-14 17:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-13 19:06 [no patch] broken use of mm_release / deactivate_mm Andries Brouwer
2004-09-13 19:30 ` Linus Torvalds
2004-09-14 12:41 ` Nick Piggin
2004-09-14 15:06 ` Linus Torvalds
2004-09-14 17:00 ` Herbert Poetzl [this message]
2004-09-14 23:21 ` Andries Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040914170019.GA3580@MAIL.13thfloor.at \
--to=herbert@13thfloor.at \
--cc=Andries.Brouwer@cwi.nl \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.