From: Andries Brouwer <Andries.Brouwer@cwi.nl>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
Andries Brouwer <Andries.Brouwer@cwi.nl>,
Andrew Morton <akpm@osdl.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [no patch] broken use of mm_release / deactivate_mm
Date: Wed, 15 Sep 2004 01:21:16 +0200 [thread overview]
Message-ID: <20040914232116.GA14580@apps.cwi.nl> (raw)
In-Reply-To: <Pine.LNX.4.58.0409140803090.2378@ppc970.osdl.org>
On Tue, Sep 14, 2004 at 08:06:14AM -0700, Linus Torvalds wrote:
> Does everybody also agree that ... mmput() does all of that correctly too?
I think so, but do not have time to check all details.
Now the first parameter of mm_release() always is current,
so that this parameter is superfluous. Similarly, the only
parameter of exit_mm() always is current, and hence is superfluous.
Maybe it is a good idea to remove the pretense that these routines
might do something useful for general parameters, now that
deactivate_mm() does sneaky global things.
Andries
prev parent reply other threads:[~2004-09-14 23:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-13 19:06 [no patch] broken use of mm_release / deactivate_mm Andries Brouwer
2004-09-13 19:30 ` Linus Torvalds
2004-09-14 12:41 ` Nick Piggin
2004-09-14 15:06 ` Linus Torvalds
2004-09-14 17:00 ` Herbert Poetzl
2004-09-14 23:21 ` Andries Brouwer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040914232116.GA14580@apps.cwi.nl \
--to=andries.brouwer@cwi.nl \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.