* [Kernel-janitors] [PATCH 2.6.9-rc2 3/33] char/drm_os_linux: replace
@ 2004-09-15 21:32 Nishanth Aravamudan
2004-09-16 7:13 ` Nishanth Aravamudan
0 siblings, 1 reply; 2+ messages in thread
From: Nishanth Aravamudan @ 2004-09-15 21:32 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 632 bytes --]
Any comments would be appreciated.
Description: Use set_current_state() instead of direct assignment of
current->state.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.9-rc1-mm4-vanilla/drivers/char/drm/drm_os_linux.h 2004-09-09 23:05:38.000000000 -0700
+++ 2.6.9-rc1-mm4/drivers/char/drm/drm_os_linux.h 2004-09-10 10:34:04.000000000 -0700
@@ -134,7 +134,7 @@ do { \
add_wait_queue(&(queue), &entry); \
\
for (;;) { \
- current->state = TASK_INTERRUPTIBLE; \
+ set_current_state(TASK_INTERRUPTIBLE); \
if (condition) \
break; \
if (time_after_eq(jiffies, end)) { \
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Kernel-janitors] [PATCH 2.6.9-rc2 3/33] char/drm_os_linux: replace
2004-09-15 21:32 [Kernel-janitors] [PATCH 2.6.9-rc2 3/33] char/drm_os_linux: replace Nishanth Aravamudan
@ 2004-09-16 7:13 ` Nishanth Aravamudan
0 siblings, 0 replies; 2+ messages in thread
From: Nishanth Aravamudan @ 2004-09-16 7:13 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 962 bytes --]
Re-submission of patch incorporating Alan Cox's suggestion of using
__set_current_state() and changing the other direct assignment in the
macro.
Thanks,
Nish
Description: Use set_current_state() instead of direct assignment of
current->state.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.9-rc2-vanilla/drivers/char/drm/drm_os_linux.h 2004-09-13 17:15:48.000000000 -0700
+++ 2.6.9-rc2/drivers/char/drm/drm_os_linux.h 2004-09-16 00:10:47.000000000 -0700
@@ -134,7 +134,7 @@ do { \
add_wait_queue(&(queue), &entry); \
\
for (;;) { \
- current->state = TASK_INTERRUPTIBLE; \
+ __set_current_state(TASK_INTERRUPTIBLE); \
if (condition) \
break; \
if (time_after_eq(jiffies, end)) { \
@@ -147,7 +147,7 @@ do { \
break; \
} \
} \
- current->state = TASK_RUNNING; \
+ __set_current_state(TASK_RUNNING); \
remove_wait_queue(&(queue), &entry); \
} while (0)
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-09-16 7:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-15 21:32 [Kernel-janitors] [PATCH 2.6.9-rc2 3/33] char/drm_os_linux: replace Nishanth Aravamudan
2004-09-16 7:13 ` Nishanth Aravamudan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.