Re: 2.6.9-rc2-mm1

[Jesse Barnes <jbarnes@engr.sgi.com>]

On Thursday, September 16, 2004 2:40 am, Andrew Morton wrote:
>  bk-acpi.patch

Looks like some changes in this patch break sn2.  In particular, this hunk in 
acpi_pci_irq_enable():

-               if (dev->irq && (dev->irq <= 0xF)) {
+               if (dev->irq >= 0 && (dev->irq <= 0xF)) {
                        printk(" - using IRQ %d\n", dev->irq);
                        return_VALUE(dev->irq);
                }
                else {
                        printk("\n");
-                       return_VALUE(0);
+                       return_VALUE(-EINVAL);
                }

Now instead of returning 0, we'll get -EINVAL when a driver calls 
pci_enable_device.  This is arguably correct since there's no _PRT entry (and 
in fact no ACPI namespace on sn2), but shouldn't the code above be looking at 
the 'pin' value instead of dev->irq?  The sn2 specific PCI code sets up each 
dev->irq long before this with the correct values...

Thanks,
Jesse