From: Jesse Barnes <jbarnes@engr.sgi.com>
To: Len Brown <len.brown@intel.com>
Cc: "Protasevich, Natalie" <Natalie.Protasevich@unisys.com>,
Bjorn Helgaas <bjorn.helgaas@hp.com>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.9-rc2-mm1
Date: Fri, 17 Sep 2004 08:57:13 -0700 [thread overview]
Message-ID: <200409170857.13631.jbarnes@engr.sgi.com> (raw)
In-Reply-To: <1095403811.2046.51.camel@d845pe>
On Thursday, September 16, 2004 11:50 pm, Len Brown wrote:
> I'm not sure exactly that the patch above was trying to fix. Looks like
> it is time to examine the latest ew7000 changes in detail. But I think
> the patch has pointed out that this routine really should be returning 0
> for success and non zero for failure; and returning dev->irq was
> probably a latent bug all along.
Right, and I'd like success to be defined a little more broadly. If dev->irq
is already valid, we should just return 0 right away. That would take care
of platforms that already have the dev in question setup properly.
Thanks,
Jesse
next prev parent reply other threads:[~2004-09-17 16:03 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-17 5:18 2.6.9-rc2-mm1 Protasevich, Natalie
2004-09-17 6:50 ` 2.6.9-rc2-mm1 Len Brown
2004-09-17 15:57 ` Jesse Barnes [this message]
2004-11-09 8:47 ` acpi_pci_irq_enable (RE: 2.6.9-rc2-mm1) Len Brown
[not found] <2F1dX-2r9-5@gated-at.bofh.it>
[not found] ` <2F7VJ-7o7-7@gated-at.bofh.it>
[not found] ` <2F8fj-7yw-39@gated-at.bofh.it>
[not found] ` <2F8oL-7DK-1@gated-at.bofh.it>
[not found] ` <2F8oR-7DK-17@gated-at.bofh.it>
[not found] ` <2FwKr-7VO-7@gated-at.bofh.it>
[not found] ` <2GAsE-21G-9@gated-at.bofh.it>
2004-09-20 19:30 ` 2.6.9-rc2-mm1 Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2004-09-16 9:40 2.6.9-rc2-mm1 Andrew Morton
2004-09-16 13:10 ` 2.6.9-rc2-mm1 Diego Calleja
2004-09-16 12:27 ` 2.6.9-rc2-mm1 Alan Cox
2004-09-16 13:34 ` 2.6.9-rc2-mm1 Ryan Cumming
2004-09-16 14:20 ` 2.6.9-rc2-mm1 William Lee Irwin III
2004-09-16 16:45 ` 2.6.9-rc2-mm1 Norberto Bensa
2004-09-16 17:16 ` 2.6.9-rc2-mm1 Arjan van de Ven
2004-09-16 17:28 ` 2.6.9-rc2-mm1 Norberto Bensa
2004-09-16 17:30 ` 2.6.9-rc2-mm1 Arjan van de Ven
2004-09-17 19:29 ` 2.6.9-rc2-mm1 Valdis.Kletnieks
2004-09-20 17:41 ` 2.6.9-rc2-mm1 Terence Ripperda
2004-09-16 17:37 ` 2.6.9-rc2-mm1 Jedi/Sector One
2004-09-16 17:57 ` 2.6.9-rc2-mm1 Norberto Bensa
2004-09-16 17:14 ` 2.6.9-rc2-mm1 Jesse Barnes
2004-09-16 17:38 ` 2.6.9-rc2-mm1 Bjorn Helgaas
2004-09-17 3:00 ` 2.6.9-rc2-mm1 Norberto Bensa
2004-09-17 18:09 ` 2.6.9-rc2-mm1 Dominik Karall
2004-09-18 1:10 ` 2.6.9-rc2-mm1 Sean Neakums
2004-09-18 6:01 ` 2.6.9-rc2-mm1 William Lee Irwin III
2004-09-18 8:18 ` 2.6.9-rc2-mm1 Russell King
2004-09-20 1:12 ` 2.6.9-rc2-mm1 William Lee Irwin III
2004-09-20 4:37 ` 2.6.9-rc2-mm1 Paul Jackson
2004-09-20 23:27 ` 2.6.9-rc2-mm1 Jesse Barnes
2004-09-20 2:34 ` 2.6.9-rc2-mm1 William Lee Irwin III
2004-09-20 4:18 ` 2.6.9-rc2-mm1 Albert Cahalan
2004-09-20 7:47 ` 2.6.9-rc2-mm1 William Lee Irwin III
2004-09-20 15:00 ` 2.6.9-rc2-mm1 Albert Cahalan
2004-09-20 21:01 ` 2.6.9-rc2-mm1 William Lee Irwin III
2004-09-20 22:20 ` 2.6.9-rc2-mm1 William Lee Irwin III
[not found] ` <200409201939.04207.>
2004-09-20 17:58 ` 2.6.9-rc2-mm1 Andrew Morton
2004-09-20 20:15 ` 2.6.9-rc2-mm1 Magnus Määttä
2004-09-20 20:45 ` 2.6.9-rc2-mm1 David Howells
2004-09-24 5:30 ` 2.6.9-rc2-mm1 William Lee Irwin III
2004-09-24 7:11 ` 2.6.9-rc2-mm1 Jens Axboe
2004-09-24 7:24 ` 2.6.9-rc2-mm1 William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200409170857.13631.jbarnes@engr.sgi.com \
--to=jbarnes@engr.sgi.com \
--cc=Natalie.Protasevich@unisys.com \
--cc=akpm@osdl.org \
--cc=bjorn.helgaas@hp.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.