* [Kernel-janitors] [PATCH 2.6.9-rc2 1/17] media/bttv-i2c: replace
@ 2004-09-20 21:39 Nishanth Aravamudan
0 siblings, 0 replies; only message in thread
From: Nishanth Aravamudan @ 2004-09-20 21:39 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 724 bytes --]
Any comments would be appreciated.
Description: Use msleep_interruptible() instead of schedule_timeout() to
guarantee the task delays as expected.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.9-rc2-vanilla/drivers/media/video/bttv-i2c.c 2004-09-13 17:15:40.000000000 -0700
+++ 2.6.9-rc2/drivers/media/video/bttv-i2c.c 2004-09-14 16:35:07.000000000 -0700
@@ -139,10 +139,8 @@ bttv_i2c_wait_done(struct bttv *btv)
int rc = 0;
add_wait_queue(&btv->i2c_queue, &wait);
- set_current_state(TASK_INTERRUPTIBLE);
if (0 == btv->i2c_done)
- schedule_timeout(HZ/50+1);
- set_current_state(TASK_RUNNING);
+ msleep_interruptible(20);
remove_wait_queue(&btv->i2c_queue, &wait);
if (0 == btv->i2c_done)
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-09-20 21:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-20 21:39 [Kernel-janitors] [PATCH 2.6.9-rc2 1/17] media/bttv-i2c: replace Nishanth Aravamudan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.