* [Kernel-janitors] [PATCH 2.6.9-rc2 12/17] media/saa7134-core:
@ 2004-09-20 22:03 Nishanth Aravamudan
0 siblings, 0 replies; only message in thread
From: Nishanth Aravamudan @ 2004-09-20 22:03 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 835 bytes --]
Any comments would be appreciated.
Description: Use msleep_interruptible() instead of schedule_timeout()
to guarantee the task delays as expected.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.9-rc2-vanilla/drivers/media/video/saa7134/saa7134-core.c 2004-09-13 17:15:39.000000000 -0700
+++ 2.6.9-rc2/drivers/media/video/saa7134/saa7134-core.c 2004-09-17 14:53:50.000000000 -0700
@@ -27,6 +27,7 @@
#include <linux/kmod.h>
#include <linux/sound.h>
#include <linux/interrupt.h>
+#include <linux/delay.h>
#include "saa7134-reg.h"
#include "saa7134.h"
@@ -910,8 +911,7 @@ static int __devinit saa7134_initdev(str
}
/* wait a bit, register i2c bus */
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(HZ/10);
+ msleep_interruptible(100);
saa7134_i2c_register(dev);
/* initialize hardware #2 */
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-09-20 22:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-20 22:03 [Kernel-janitors] [PATCH 2.6.9-rc2 12/17] media/saa7134-core: Nishanth Aravamudan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.