[Kernel-janitors] [PATCH 2.6.9-rc2 15/17] media/tda9887: replace

[Kernel-janitors] [PATCH 2.6.9-rc2 15/17] media/tda9887: replace

[Nishanth Aravamudan]

[-- Attachment #1: Type: text/plain, Size: 851 bytes --]

Any comments would be appreciated.

Description: Use msleep_interruptible() instead of schedule_timeout()
to guarantee the task delays as expected.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

--- 2.6.9-rc1-mm4-vanilla/drivers/media/video/tda9887.c	2004-09-09 23:05:26.000000000 -0700
+++ 2.6.9-rc1-mm4/drivers/media/video/tda9887.c	2004-09-13 14:27:26.000000000 -0700
@@ -6,6 +6,7 @@
 #include <linux/init.h>
 #include <linux/errno.h>
 #include <linux/slab.h>
+#include <linux/delay.h>
 
 #include <media/audiochip.h>
 #include <media/tuner.h>
@@ -543,8 +544,7 @@ static int tda9887_configure(struct tda9
                 printk(PREFIX "i2c i/o error: rc == %d (should be 4)\n",rc);
 
 	if (debug > 2) {
-		set_current_state(TASK_INTERRUPTIBLE);
-		schedule_timeout(HZ);
+		msleep_interruptible(1000);
 		tda9887_status(t);
 	}
 	return 0;

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors