Re: a fix for NS87415 on C3K broken

[Grant Grundler <grundler@parisc-linux.org>]

On Wed, Sep 22, 2004 at 12:41:21PM +0200, Joel Soete wrote:
> Hello Grant, Bartlomiej and *,
>
> I test this patch:
> --- arch/parisc/kernel/pci.c.Orig	2004-09-22 09:47:02.000000000 +0200
> +++ arch/parisc/kernel/pci.c	2004-09-22 11:26:02.104187784 +0200
> @@ -146,6 +146,9 @@
>  	return str;
>  }
> 
> +/* Used in drivers/pci/quirks.c */
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_NS, PCI_DEVICE_ID_NS_87415, superio_fixup_pci);

Uhm...any clue why this works?
The same entry in drivers/parisc/superio.c should work too but it doesn't.
I'd rather fix that than just blindly moving it.

> That fix the NS87415 pb on my c2k model :)
> Can somebody check it with some c3k model?

I expect c3k also to work. I'm not going to test it.


BTW, I've prepared a patch which moves IDE knowledge
out of superio.c driver and into drivers/ide/pci/ns87415.c.
I've not submitted it yet because I haven't successfully tested it
and it still contains debug printk's.
It builds and anyone curious is welcome to look at it:
    ftp://ftp.parisc-linux.org/patches/diff-2.6.9-rc2-ns87415_suckyio_cleanup-01

Moving the DECLARE_PCI_FIXUP_HEADER() around is probably the clue
I needed to resolve this.

thanks,
grant