Re: a fix for NS87415 on C3K broken

["Joel Soete" <soete.joel@tiscali.be>]

Hello Grant,

> On Wed, Sep 22, 2004 at 12:41:21PM +0200, Joel Soete wrote:
> > Hello Grant, Bartlomiej and *,
> >
> > I test this patch:
> > --- arch/parisc/kernel/pci.c.Orig	2004-09-22 09:47:02.000000000 +0200
> > +++ arch/parisc/kernel/pci.c	2004-09-22 11:26:02.104187784 +0200
> > @@ -146,6 +146,9 @@
> >  	return str;
> >  }
> > 
> > +/* Used in drivers/pci/quirks.c */
> > +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_NS, PCI_DEVICE_ID_NS_87415,
superio_fixup_pci);
> 
> Uhm...any clue why this works?
No more clue sorry; I just notived that boot message of 2.6.8.1-pa7:
lba version TR4.0 (0x5) found at 0xfffffffffed30000
PCI: Enabled native mode for NS87415 (pif=0x8f)

became with 2.6.9-rc2:
lba version TR4.0 (0x5) found at 0xfffffffffed30000
PCI: Ignoring BAR0-3 of IDE controller 0000:00:0e.0
PCI: Enabled native mode for NS87415 (pif=0x8f)

(so PCI: Enabled native mode for NS87415 precede by a weird 'ignoring ...
IDE controler)

I so just try to move back the pcibios_fixups initialisation at its previous
place and the message ''ignoring ... IDE controler" disapear ?)
 
> The same entry in drivers/parisc/superio.c should work too but it doesn't.
> I'd rather fix that than just blindly moving it.
> 
no pb

> > That fix the NS87415 pb on my c2k model :)
> > Can somebody check it with some c3k model?
> 
> I expect c3k also to work. I'm not going to test it.
> 
> 
> BTW, I've prepared a patch which moves IDE knowledge
> out of superio.c driver and into drivers/ide/pci/ns87415.c.
> I've not submitted it yet because I haven't successfully tested it
> and it still contains debug printk's.
> It builds and anyone curious is welcome to look at it:
>     ftp://ftp.parisc-linux.org/patches/diff-2.6.9-rc2-ns87415_suckyio_cleanup-01
> 
I will also try it :)

> Moving the DECLARE_PCI_FIXUP_HEADER() around is probably the clue
> I needed to resolve this.
> 
I am curious to find an expalnation too.

Thanks,
    Joel

---------------------------------------------------------------------------
Tiscali ADSL GO, 29,50 Euro/mois pendant toute une année, profitez-en...
http://reg.tiscali.be/adsl/welcome.asp?lg=FR