From: William Lee Irwin III <wli@holomorphy.com>
To: Thomas Habets <thomas@habets.pp.se>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] oom_pardon, aka don't kill my xlock
Date: Wed, 22 Sep 2004 17:07:33 -0700 [thread overview]
Message-ID: <20040923000733.GT9106@holomorphy.com> (raw)
In-Reply-To: <200409230123.30858.thomas@habets.pp.se>
On Thu, Sep 23, 2004 at 01:23:08AM +0200, Thomas Habets wrote:
> How about a sysctl that does "for the love of kbaek, don't ever kill these
> processes when OOM. If nothing else can be killed, I'd rather you panic"?
> Examples for this list would be /usr/bin/vlock and /usr/X11R6/bin/xlock.
> I just got a very uncomfortable surprise when found my box unlocked thanks to
> this.
> After playing around a bit, I made the patch below, but it's almost
> completely untested. I'm not even sure I take the binaries name from
> the right place. And I don't know if the locking can race. If it's
> too ugly then it'd be great if someone implemented it the right way.
> (iow: huge fucking disclaimer)
> echo "/usr/bin/vlock /usr/X11R6/bin/xlock" > /proc/sys/vm/oom_pardon
Assuming this is desirable (otherwise, why would you have written it?)
(1) uts_sem isn't the right lock.
(2) You acquire uts_sem under tasklist_lock, a deadlock.
(3) It would probably make more sense to dynamically register and
unregister the various criteria for exempt processes than mess
with space-separated fields of a single string.
-- wli
next prev parent reply other threads:[~2004-09-23 0:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-22 23:23 [PATCH] oom_pardon, aka don't kill my xlock Thomas Habets
2004-09-23 0:01 ` Nick Piggin
2004-09-23 0:07 ` William Lee Irwin III [this message]
2004-09-23 4:45 ` Tonnerre
2004-09-23 6:57 ` Thomas Habets
2004-09-23 12:24 ` Tonnerre
2004-09-23 13:32 ` Thomas Habets
2004-09-23 23:45 ` Andries Brouwer
2004-09-24 13:19 ` Alan Cox
2004-09-24 19:58 ` Thomas Habets
2004-09-24 21:15 ` Alan Cox
2004-09-25 10:08 ` Thomas Habets
2004-09-27 10:41 ` Marcelo Tosatti
2004-09-27 12:54 ` Lars Marowsky-Bree
2004-09-27 13:12 ` Jon Masters
2004-09-27 12:36 ` Alan Cox
2004-09-27 13:35 ` Marcelo Tosatti
2004-09-27 15:59 ` Jon Masters
2004-09-27 17:12 ` Herbert Poetzl
2004-09-27 16:42 ` Marcelo Tosatti
2004-09-28 13:33 ` Herbert Poetzl
2004-09-28 12:32 ` Marcelo Tosatti
2004-09-28 23:55 ` Herbert Poetzl
2004-09-27 23:07 ` Jon Masters
2004-09-29 0:49 ` Andries Brouwer
2004-09-24 14:07 ` Pavel Machek
2004-09-24 22:57 ` Jon Masters
2004-09-25 16:32 ` Andrea Arcangeli
-- strict thread matches above, loose matches on Subject: below --
2004-09-27 12:00 Thomas Habets
2004-09-27 12:17 ` Jon Masters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040923000733.GT9106@holomorphy.com \
--to=wli@holomorphy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@habets.pp.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.