[Kernel-janitors] [PATCH 2.6.9-rc2 2/5] pcmcia/ds: replace

[Kernel-janitors] [PATCH 2.6.9-rc2 2/5] pcmcia/ds: replace

[Nishanth Aravamudan]

[-- Attachment #1: Type: text/plain, Size: 882 bytes --]

Any comments would be appreciated.

Description: Use msleep_interruptible() instead of
schedule_timeout() to guarantee the task delays as expected.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

--- 2.6.9-rc2-vanilla/drivers/pcmcia/ds.c	2004-09-13 17:16:07.000000000 -0700
+++ 2.6.9-rc2/drivers/pcmcia/ds.c	2004-09-27 09:46:12.000000000 -0700
@@ -51,6 +51,7 @@
 #include <linux/pci.h>
 #include <linux/list.h>
 #include <linux/workqueue.h>
+#include <linux/delay.h>
 
 #include <asm/atomic.h>
 
@@ -1080,8 +1081,7 @@ static int __devinit pcmcia_bus_add_sock
 	 * Ugly. But we want to wait for the socket threads to have started up.
 	 * We really should let the drivers themselves drive some of this..
 	 */
-	current->state = TASK_INTERRUPTIBLE;
-	schedule_timeout(HZ/4);
+	msleep_interruptible(250);
 
 	init_waitqueue_head(&s->queue);
 	init_waitqueue_head(&s->request);

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors