* [Kernel-janitors] [PATCH 2.6.9-rc2 12/16] scsi/sata_sx4: replace
@ 2004-09-27 18:29 ` Nishanth Aravamudan
0 siblings, 0 replies; 2+ messages in thread
From: Nishanth Aravamudan @ 2004-09-27 18:29 UTC (permalink / raw)
To: James.Bottomley, jgarzik; +Cc: kernel-janitors, linux-ide
[-- Attachment #1: Type: text/plain, Size: 841 bytes --]
Any comments would be appreciated.
Description: Use msleep()/ssleep() [as appropriate]
instead of schedule_timeout() to guarantee the task delays as
expected.
--- 2.6.9-rc2-vanilla/drivers/scsi/sata_sx4.c 2004-09-13 17:15:56.000000000 -0700
+++ 2.6.9-rc2/drivers/scsi/sata_sx4.c 2004-09-27 11:28:10.000000000 -0700
@@ -1189,8 +1189,7 @@ static unsigned int pdc20621_prog_dimm_g
error = 0;
break;
}
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout((i * 100) * HZ / 1000 + 1);
+ msleep(i * 100);
}
return error;
}
@@ -1223,8 +1222,7 @@ static unsigned int pdc20621_dimm_init(s
readl(mmio + PDC_TIME_CONTROL);
/* Wait 3 seconds */
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(3 * HZ);
+ ssleep(3);
/*
When timer is enabled, counter is decreased every internal
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 2.6.9-rc2 12/16] scsi/sata_sx4: replace schedule_timeout() with msleep()/ssleep()
@ 2004-09-27 18:29 ` Nishanth Aravamudan
0 siblings, 0 replies; 2+ messages in thread
From: Nishanth Aravamudan @ 2004-09-27 18:29 UTC (permalink / raw)
To: James.Bottomley, jgarzik; +Cc: kernel-janitors, linux-ide
Any comments would be appreciated.
Description: Use msleep()/ssleep() [as appropriate]
instead of schedule_timeout() to guarantee the task delays as
expected.
--- 2.6.9-rc2-vanilla/drivers/scsi/sata_sx4.c 2004-09-13 17:15:56.000000000 -0700
+++ 2.6.9-rc2/drivers/scsi/sata_sx4.c 2004-09-27 11:28:10.000000000 -0700
@@ -1189,8 +1189,7 @@ static unsigned int pdc20621_prog_dimm_g
error = 0;
break;
}
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout((i * 100) * HZ / 1000 + 1);
+ msleep(i * 100);
}
return error;
}
@@ -1223,8 +1222,7 @@ static unsigned int pdc20621_dimm_init(s
readl(mmio + PDC_TIME_CONTROL);
/* Wait 3 seconds */
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(3 * HZ);
+ ssleep(3);
/*
When timer is enabled, counter is decreased every internal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-09-27 18:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-27 18:29 [Kernel-janitors] [PATCH 2.6.9-rc2 12/16] scsi/sata_sx4: replace Nishanth Aravamudan
2004-09-27 18:29 ` [PATCH 2.6.9-rc2 12/16] scsi/sata_sx4: replace schedule_timeout() with msleep()/ssleep() Nishanth Aravamudan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.