* [Kernel-janitors] [PATCH 2.6.9-rc2 5/6] serial/pmac_zilog: replace
@ 2004-09-27 21:26 Nishanth Aravamudan
0 siblings, 0 replies; only message in thread
From: Nishanth Aravamudan @ 2004-09-27 21:26 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 891 bytes --]
Any comments would be appreciated.
Description: Use msleep() instead of schedule_timeout() to
guarantee the task delays as expected.
--- 2.6.9-rc2-vanilla/drivers/serial/pmac_zilog.c 2004-09-13 17:15:52.000000000 -0700
+++ 2.6.9-rc2/drivers/serial/pmac_zilog.c 2004-09-14 10:16:17.000000000 -0700
@@ -949,8 +949,7 @@ static int pmz_startup(struct uart_port
*/
if (pwr_delay != 0) {
pmz_debug("pmz: delaying %d ms\n", pwr_delay);
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout((pwr_delay * HZ)/1000);
+ msleep(pwr_delay);
}
/* IrDA reset is done now */
@@ -1684,8 +1683,7 @@ static int pmz_resume(struct macio_dev *
*/
if (pwr_delay != 0) {
pmz_debug("pmz: delaying %d ms\n", pwr_delay);
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout((pwr_delay * HZ)/1000);
+ msleep(pwr_delay);
}
pmz_debug("resume, switching complete\n");
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-09-27 21:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-27 21:26 [Kernel-janitors] [PATCH 2.6.9-rc2 5/6] serial/pmac_zilog: replace Nishanth Aravamudan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.