All of lore.kernel.org
 help / color / mirror / Atom feed
* [Kernel-janitors] [PATCH 2.6.9-rc2 1/10] usb/ati_remote: add
@ 2004-09-27 21:35 Nishanth Aravamudan
  0 siblings, 0 replies; only message in thread
From: Nishanth Aravamudan @ 2004-09-27 21:35 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 714 bytes --]

Any comments would be appreciated.

Description: Add set_current_state() before schedule_timeout() so that
if the while-loop iterates multiple times, schedule_timeout() delays as
expected. Without the addition, schedule_timeout() will return
immediately.

--- 2.6.9-rc2-vanilla/drivers/usb/input/ati_remote.c	2004-09-13 17:15:54.000000000 -0700
+++ 2.6.9-rc2/drivers/usb/input/ati_remote.c	2004-09-27 14:33:12.000000000 -0700
@@ -418,6 +418,7 @@ static int ati_remote_sendpacket(struct 
 
 	while (timeout && (ati_remote->out_urb->status == -EINPROGRESS) 
 	       && !(ati_remote->send_flags & SEND_FLAG_COMPLETE)) {
+		set_current_state(TASK_INTERRUPTIBLE);
 		timeout = schedule_timeout(timeout);
 		rmb();
 	}

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-09-27 21:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-27 21:35 [Kernel-janitors] [PATCH 2.6.9-rc2 1/10] usb/ati_remote: add Nishanth Aravamudan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.