All of lore.kernel.org
 help / color / mirror / Atom feed
* [Kernel-janitors] [PATCH 2.6.9-rc2 6/9] usb/kaweth: reorder
@ 2004-09-27 22:20 Nishanth Aravamudan
  0 siblings, 0 replies; only message in thread
From: Nishanth Aravamudan @ 2004-09-27 22:20 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

Any comments would be appreciated.

Description: Reorder set_current_state() and schedule_timeout() for a
minor cleanup. The reorder allows removing two of the
set_current_state() calls.

--- 2.6.9-rc2-vanilla/drivers/usb/net/kaweth.c	2004-09-13 17:15:55.000000000 -0700
+++ 2.6.9-rc2/drivers/usb/net/kaweth.c	2004-09-15 10:06:18.000000000 -0700
@@ -1250,13 +1250,11 @@ static int usb_start_wait_urb(struct urb
                 return status;
         }
 
-	set_current_state(TASK_UNINTERRUPTIBLE);
 	while (timeout && !awd.done) {
-		timeout = schedule_timeout(timeout);
 		set_current_state(TASK_UNINTERRUPTIBLE);
+		timeout = schedule_timeout(timeout);
 	}
 
-        set_current_state(TASK_RUNNING);
         remove_wait_queue(&awd.wqh, &wait);
 
         if (!timeout) {

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-09-27 22:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-27 22:20 [Kernel-janitors] [PATCH 2.6.9-rc2 6/9] usb/kaweth: reorder Nishanth Aravamudan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.