[Kernel-janitors] Re: sbus/aurora: replace schedule_timeout() with

[Kernel-janitors] Re: sbus/aurora: replace schedule_timeout() with

[Domen Puncer]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

On 27/09/04 10:24 -0700, Nishanth Aravamudan wrote:
> -			current->state = TASK_INTERRUPTIBLE;
> -			schedule_timeout(port->close_delay);
> +			msleep_interruptible(port->close_delay);

I think you forgot jiffies_to_msecs here.


	Domen

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] Re: sbus/aurora: replace schedule_timeout() with

[Nishanth Aravamudan]

[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]

On Wed, Sep 29, 2004 at 06:10:06PM +0200, Domen Puncer wrote:
> On 27/09/04 10:24 -0700, Nishanth Aravamudan wrote:
> > -			current->state = TASK_INTERRUPTIBLE;
> > -			schedule_timeout(port->close_delay);
> > +			msleep_interruptible(port->close_delay);
> 
> I think you forgot jiffies_to_msecs here.

Please find the corrected patch below.
Thanks for catching this, Domen.


--- 2.6.9-rc2-vanilla/drivers/sbus/char/aurora.c	2004-09-13 17:16:08.000000000 -0700
+++ 2.6.9-rc2/drivers/sbus/char/aurora.c	2004-09-29 10:19:14.000000000 -0700
@@ -1519,8 +1519,7 @@ static void aurora_close(struct tty_stru
 		 */
 		timeout = jiffies+HZ;
 		while(port->SRER & SRER_TXEMPTY)  {
-			current->state = TASK_INTERRUPTIBLE;
-			schedule_timeout(port->timeout);
+			msleep_interruptible(jiffies_to_msecs(port->timeout));
 			if (time_after(jiffies, timeout))
 				break;
 		}
@@ -1538,8 +1537,7 @@ static void aurora_close(struct tty_stru
 	port->tty = 0;
 	if (port->blocked_open) {
 		if (port->close_delay) {
-			current->state = TASK_INTERRUPTIBLE;
-			schedule_timeout(port->close_delay);
+			msleep_interruptible(jiffies_to_msecs(port->close_delay));
 		}
 		wake_up_interruptible(&port->open_wait);
 	}

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors