Re: [Patch] Fix oops on rmmod usb-storage

[Mike Anderson <andmike@us.ibm.com>]

Christoph Hellwig [hch@infradead.org] wrote:
> On Wed, Sep 29, 2004 at 01:19:28PM -0400, James Bottomley wrote:
> > On Wed, 2004-09-29 at 13:12, Mike Anderson wrote:
> > > We may want to reconsider a method to distinguish unexpected removals
> > > from clean removals.
> > 
> > Technically we have this: it's the recovery flag to scsi_host_cancel(). 
> > Unfortunately, scsi_remove_host doesn't have such a flag so it's always
> > set to zero at the moment.
> 
> and ->remove for the bus drivers doesn't know either, so adding such
> a flag wouldn't help us much.

In some cases the knowledge would be in the driver would it not. When the
drivers remove function is called the driver knows the state of the
transport or in the case of the usb storage device it knows it will
not process anymore commands. 

Alan / Matthew / others can correct if I have mis-read something in
usb_stor_release_resources but it knows that it will not process anymore
commands prior to calling scsi_remove_host so if we had a method to flag
this it would help in our shutdown if we want to support both devices
that can and cannot process commands.

-andmike
--
Michael Anderson
andmike@us.ibm.com