From: Hannes Reinecke <hare@suse.de>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [Patch] Fix oops on rmmod usb-storage
Date: Wed, 29 Sep 2004 16:44:28 +0200 [thread overview]
Message-ID: <415ACA4C.807@suse.de> (raw)
In-Reply-To: <1096467874.1762.15.camel@mulgrave>
[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]
James Bottomley wrote:
> On Wed, 2004-09-29 at 09:17, Alan Cox wrote:
>
>>On Mer, 2004-09-29 at 14:56, James Bottomley wrote:
>>
>>>The key to the solution of this problem is to know what USB is trying to
>>>do with the dead device. SCSI is trying to be polite and explicitly
>>>kill the outstanding commands before it removes the HBA. Presumably USB
>>>is returning something that says this can't be done so the EH gets all
>>>the way up to offlining.
>>
>>Its nothing to do with USB, rmmod with eh running crashes all the other
>>SCSI drivers I've tested too. After the state transition fails you get
>>kobject related errors and a crash.
>
>
> There is no crash in the log ... there was only a state transition
> complaint.
>
Oh, that can be fixed. Attached is the full trace (including USB
debugging output).
It does crash. Hard.
Cheers,
Hannes
--
Dr. Hannes Reinecke hare@suse.de
SuSE Linux AG S390 & zSeries
Maxfeldstraße 5 +49 911 74053 688
90409 Nürnberg http://www.suse.de
[-- Attachment #2: usb-scsi-remove.oops --]
[-- Type: text/plain, Size: 6685 bytes --]
ehci_hcd 0000:00:1d.7: GetStatus port 5 status 001002 POWER sig=se0
CSC
hub 4-0:1.0: port 5, status 0100, change 0001, 12 Mb/s
usb 4-5: USB disconnect, address 4
usb 4-5: usb_disable_device nuking all URBs
usb 4-5: unregistering interface 4-5:1.0
bus usb: remove device 4-5:1.0
usb-storage: storage_disconnect() called
usb-storage: usb_stor_stop_transport called
CLASS: Unregistering class device. ID = '0:0:0:0'
CLASS: Unregistering class device. ID = 'sg0'
class_hotplug - name = sg0
device class 'sg0': release.
class_hotplug - name = 0:0:0:0
device class '0:0:0:0': release.
bus scsi: remove device 0:0:0:0
usb-storage: queuecommand called
usb-storage: *** thread awakened.
usb-storage: No command during disconnect
usb-storage: *** thread sleeping.
usb-storage: command_abort called
usb-storage: -- nothing to abort
usb-storage: device_reset called
usb-storage: No reset during disconnect
usb-storage: bus_reset called
usb-storage: No reset during disconnect
scsi: Device offlined - not ready after error recovery: host 0 channel
0 id 0 lun 0
sr 0:0:0:0: Illegal state transition cancel->offline
Badness in scsi_device_set_state at drivers/scsi/scsi_lib.c:1688
[<c0107235>] dump_stack+0x15/0x20
[<e0ef8e46>] scsi_device_set_state+0xa6/0xe0 [scsi_mod]
[<e0ef6c62>] scsi_eh_offline_sdevs+0x52/0x70 [scsi_mod]
[<e0ef7128>] scsi_unjam_host+0x98/0x1b0 [scsi_mod]
[<e0ef7305>] scsi_error_handler+0xc5/0x160 [scsi_mod]
[<c0104269>] kernel_thread_helper+0x5/0xc
Badness in kref_get at lib/kref.c:32
[<c0107235>] dump_stack+0x15/0x20
[<c01d575e>] kref_get+0x2e/0x40
[<c01d53e2>] kobject_get+0x12/0x20
[<c0246d41>] get_device+0x11/0x20
[<e0ef85c1>] scsi_request_fn+0x21/0x390 [scsi_mod]
[<c024d24e>] blk_insert_request+0x7e/0xa0
[<e0ef7673>] scsi_queue_insert+0x63/0xa0 [scsi_mod]
[<e0ef6fe8>] scsi_eh_flush_done_q+0x58/0x100 [scsi_mod]
[<e0ef7103>] scsi_unjam_host+0x73/0x1b0 [scsi_mod]
[<e0ef7305>] scsi_error_handler+0xc5/0x160 [scsi_mod]
[<c0104269>] kernel_thread_helper+0x5/0xc
Unable to handle kernel paging request at virtual address 00100104
printing eip:
e0efa735
*pde = 00000000
Oops: 0002 [#1]
Modules linked in: usb_storage rfcomm hidp l2cap hci_usb bluetooth
snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device usbhid joydev sg
st sd_mod sr_mod scsi_mod ide_cd cdrom nvram usbserial parport_pc lp
parport autofs cpufreq_userspace edd speedstep_centrino freq_table
thermal processor fan button battery ac snd_pcm_oss snd_mixer_oss
snd_intel8x0 snd_ac97_codec snd_pcm snd_timer snd soundcore
snd_page_alloc ipv6 af_packet ds ohci_hcd e100 mii ehci_hcd intel_agp
agpgart ohci1394 uhci_hcd yenta_socket ieee1394 pcmcia_core evdev
dm_mod usbcore reiserfs
CPU: 0
EIP: 0060:[<e0efa735>] Tainted: G U VLI
EFLAGS: 00010082 (2.6.8-0-defaultbt )
EIP is at scsi_device_dev_release+0x25/0x100 [scsi_mod]
eax: d2e82184 ebx: d2e82008 ecx: 00200200 edx: 00100100
esi: d2e82000 edi: 00000282 ebp: d25f3efc esp: d25f3eec
ds: 007b es: 007b ss: 0068
Process scsi_eh_0 (pid: 7063, threadinfo=d25f2000 task=d7a84000)
Stack: c157dcb4 d2e821a8 c038ad08 c038ad20 d25f3f04 c0246a83 d25f3f1c
c01d546a
c157dcd8 d2e821c0 c01d5470 c157dc00 d25f3f2c c01d5799 c157deb0
d2e82000
d25f3f48 e0ef8829 d2e82184 cdca00e8 c157deb0 00000001 cdca00e8
d25f3f60
Call Trace:
[<c010720b>] show_stack+0x9b/0xb0
[<c010735a>] show_registers+0x11a/0x190
[<c0107517>] die+0xb7/0x130
[<c0118dde>] do_page_fault+0x38e/0x5ca
[<c0106dfd>] error_code+0x2d/0x40
[<c0246a83>] device_release+0x43/0x50
[<c01d546a>] kobject_cleanup+0x7a/0x80
[<c01d5799>] kref_put+0x29/0x70
[<e0ef8829>] scsi_request_fn+0x289/0x390 [scsi_mod]
[<c024d24e>] blk_insert_request+0x7e/0xa0
[<e0ef7673>] scsi_queue_insert+0x63/0xa0 [scsi_mod]
[<e0ef6fe8>] scsi_eh_flush_done_q+0x58/0x100 [scsi_mod]
[<e0ef7103>] scsi_unjam_host+0x73/0x1b0 [scsi_mod]
[<e0ef7305>] scsi_error_handler+0xc5/0x160 [scsi_mod]
[<c0104269>] kernel_thread_helper+0x5/0xc
Code: 42 c6 34 df 89 f6 55 89 e5 57 56 53 51 8d b0 7c fe ff ff 8b 50
20 89 55 f0 9c 5f fa 8d 98 84 fe ff ff 8b 90 84 fe ff ff 8b 4b 04 <89>
4a 04 c7 43 04 00 02 20 00 89 11 8d 98 8c fe ff ff 8b 90 8c
Badness in kref_get at lib/kref.c:32
[<c0107235>] dump_stack+0x15/0x20
[<c01d575e>] kref_get+0x2e/0x40
[<c01d53e2>] kobject_get+0x12/0x20
[<c0246d41>] get_device+0x11/0x20
[<e0ef85c1>] scsi_request_fn+0x21/0x390 [scsi_mod]
[<c024ca01>] __generic_unplug_device+0x31/0x40
[<c024ca49>] blk_unplug_work+0x9/0x10
[<c012b125>] worker_thread+0x155/0x1f0
[<c012e905>] kthread+0x85/0xb0
[<c0104269>] kernel_thread_helper+0x5/0xc
Unable to handle kernel paging request at virtual address 00100104
printing eip:
e0efa735
*pde = 00000000
Oops: 0002 [#2]
Modules linked in: usb_storage rfcomm hidp l2cap hci_usb bluetooth
snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device usbhid joydev sg
st sd_mod sr_mod scsi_mod ide_cd cdrom nvram usbserial parport_pc lp
parport autofs cpufreq_userspace edd speedstep_centrino freq_table
thermal processor fan button battery ac snd_pcm_oss snd_mixer_oss
snd_intel8x0 snd_ac97_codec snd_pcm snd_timer snd soundcore
snd_page_alloc ipv6 af_packet ds ohci_hcd e100 mii ehci_hcd intel_agp
agpgart ohci1394 uhci_hcd yenta_socket ieee1394 pcmcia_core evdev
dm_mod usbcore reiserfs
CPU: 0
EIP: 0060:[<e0efa735>] Tainted: G U VLI
EFLAGS: 00010082 (2.6.8-0-defaultbt )
EIP is at scsi_device_dev_release+0x25/0x100 [scsi_mod]
eax: d2e82184 ebx: d2e82008 ecx: 00200200 edx: 00100100
esi: d2e82000 edi: 00000282 ebp: c1551ef0 esp: c1551ee0
ds: 007b es: 007b ss: 0068
Process kblockd/0 (pid: 32, threadinfo=c1550000 task=cdf8baa0)
Stack: c157dcb4 d2e821a8 c038ad08 c038ad20 c1551ef8 c0246a83 c1551f10
c01d546a
c157dcd8 d2e821c0 c01d5470 c157dc00 c1551f20 c01d5799 c157deb0
d2e82000
c1551f3c e0ef8829 d2e82184 cdca00e8 cdca00e8 c14d6e80 cdca01e0
c1551f48
Call Trace:
[<c010720b>] show_stack+0x9b/0xb0
[<c010735a>] show_registers+0x11a/0x190
[<c0107517>] die+0xb7/0x130
[<c0118dde>] do_page_fault+0x38e/0x5ca
[<c0106dfd>] error_code+0x2d/0x40
[<c0246a83>] device_release+0x43/0x50
[<c01d546a>] kobject_cleanup+0x7a/0x80
[<e0ef8829>] scsi_request_fn+0x289/0x390 [scsi_mod]
[<c024ca01>] __generic_unplug_device+0x31/0x40
[<c024ca19>] generic_unplug_device+0x9/0x10
[<c024ca49>] blk_unplug_work+0x9/0x10
[<c012b125>] worker_thread+0x155/0x1f0
[<c012e905>] kthread+0x85/0xb0
[<c0104269>] kernel_thread_helper+0x5/0xc
Code: 42 c6 34 df 89 f6 55 89 e5 57 56 53 51 8d b0 7c fe ff ff 8b 50
20 89 55 f0 9c 5f fa 8d 98 84 fe ff ff 8b 90 84 fe ff ff 8b 4b 04 <89>
4a 04 c7 43 04 00 02 20 00 89 11 8d 98 8c fe ff ff 8b 90 8c
next prev parent reply other threads:[~2004-09-29 14:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-29 7:43 [Patch] Fix oops on rmmod usb-storage Hannes Reinecke
2004-09-29 12:03 ` Christoph Hellwig
2004-09-29 12:31 ` Hannes Reinecke
2004-09-29 17:12 ` Mike Anderson
2004-09-29 17:19 ` James Bottomley
2004-09-29 17:22 ` Christoph Hellwig
2004-09-29 17:36 ` Mike Anderson
2004-09-29 17:38 ` Christoph Hellwig
2004-09-29 17:50 ` Alan Stern
2004-09-29 18:32 ` Mike Anderson
2004-09-29 18:58 ` Alan Stern
2004-09-30 8:09 ` Hannes Reinecke
2004-09-30 18:14 ` Alan Stern
2004-10-01 7:11 ` Hannes Reinecke
2004-10-01 16:07 ` Alan Stern
2004-09-29 17:52 ` Mike Anderson
2004-09-29 12:04 ` Alan Cox
2004-09-29 13:56 ` James Bottomley
2004-09-29 13:17 ` Alan Cox
2004-09-29 14:24 ` James Bottomley
2004-09-29 14:44 ` Hannes Reinecke [this message]
2004-09-29 15:15 ` James Bottomley
2004-09-29 15:15 ` James Bottomley
2004-09-29 15:28 ` Matthew Wilcox
2004-09-29 15:35 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=415ACA4C.807@suse.de \
--to=hare@suse.de \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.