[Kernel-janitors] Re: usb/auerswald: reorder set_current_state()

[Domen Puncer <domen@coderock.org>]

[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]

On 29/09/04 10:22 -0700, Nishanth Aravamudan wrote:
> On Wed, Sep 29, 2004 at 06:30:14PM +0200, Domen Puncer wrote:
> > On 27/09/04 14:46 -0700, Nishanth Aravamudan wrote:
> > > +++ 2.6.9-rc2/drivers/usb/misc/auerswald.c	2004-09-27 14:42:24.000000000 -0700
> > > @@ -626,8 +626,8 @@ static int auerchain_start_wait_urb (pau
> > >  
> > >  	while (timeout && !chs.done)
> > >  	{
> > > -		timeout = schedule_timeout (timeout);
> > >  		set_current_state(TASK_UNINTERRUPTIBLE);
> > > +		timeout = schedule_timeout (timeout);
> > >  		rmb();
> > >  	}
> > >
> > Now "set_current_state (TASK_RUNNING);" a line under this isn't
> > needed anymore, right?
> 
> I think it is still needed, because the state is initially set just before
> add_wait_queue() [before the if] to TASK_UNINTERRUPTIBLE. So, in the off
> chance that the while-loop's condition is false on the first iteration,
> the state needs to be set back to TASK_RUNNING, since schedule_timeout()
> won't be run at all.

You're right, missed that.
So... in the first iteration, schedule won't return instantly =>
patch isn't needed?


	Domen

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors