From: Jeremy Higdon <jeremy@sgi.com>
To: Dave <dave.jiang@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
jeremy.higdon@sgi.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] updates to Vitesse SATA driver
Date: Wed, 29 Sep 2004 19:34:28 -0700 [thread overview]
Message-ID: <20040930023428.GA200873@sgi.com> (raw)
In-Reply-To: <8746466a0409291532471417b8@mail.gmail.com>
On Wed, Sep 29, 2004 at 03:32:34PM -0700, Dave wrote:
> On Wed, 29 Sep 2004 18:19:40 -0400, Jeff Garzik <jgarzik@pobox.com> wrote:
> > So where did the discussion on this patch land?
The only part that made sense to me was the LED patch, which should
just be a single line of code.
> Jeff,
>
> I believe waiting for you to comment on whether to put in a hook for
> controllers that do not support ATA_NIEN so it can mask/unmask IRQ
> with a fixup. Even though the spec for this particular SATA
> controller says the bit is reserved, it seems to work just fine. From
> my understanding, the registers are actually on the drives, and the
> ones we write to the HBAs are just shadow registers right? I suppose
> either we can use the "undocumented" reserved bit for ATA_NIEN, or
> provide some sort of special hook in lib_ata core to clear the
> interrupt bit....
I don't think we need this. In vsc_sata_tf_load(), we see if the
ATA_NIEN bit has changed and call vsc_intr_mask_update() as
necessary.
> Obviosly if it is working on IA32 or IA64, this code must be only
> scanning device 0 per port and not device 1. Not sure why it is only
> scanning 1 device on IA platforms, but both on XScale. Either way we
> have a corner case here that should be addressed....
Jeff, I don't remember how libata knows how many devices a port
can have. Which field is it?
jeremy
next prev parent reply other threads:[~2004-09-30 2:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-21 21:16 [PATCH] updates to Vitesse SATA driver Dave
2004-09-22 2:06 ` Jeremy Higdon
2004-09-22 15:59 ` Dave
2004-09-22 17:09 ` Dave
2004-09-22 20:13 ` Jeremy Higdon
2004-09-23 22:28 ` Dave
2004-09-22 20:07 ` Jeremy Higdon
2004-09-29 22:19 ` Jeff Garzik
2004-09-29 22:32 ` Dave
2004-09-30 2:34 ` Jeremy Higdon [this message]
2004-09-30 3:28 ` Jeff Garzik
2004-09-30 4:05 ` Jeremy Higdon
2004-09-30 4:25 ` [PATCH 2.6.9-rc2] per-port LED control for sata_vsc Jeremy Higdon
2004-09-30 16:17 ` [PATCH] updates to Vitesse SATA driver Dave
2004-09-30 16:51 ` Dave
2004-09-30 3:32 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040930023428.GA200873@sgi.com \
--to=jeremy@sgi.com \
--cc=dave.jiang@gmail.com \
--cc=jeremy.higdon@sgi.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.